[Moon-dg]

Summary

• Implemented backend canonical phone number normalization before database persistence and uniqueness checks under Big Rock [Big Rock] Establish account onboarding and data-quality foundations #144.
• Strips non-digit characters (preserving the leading + for international country codes) in UserCreate Pydantic model to guarantee strict uniqueness and prevent duplicate accounts created via varied formatting.

Changes Made

• backend/src/models.py:
  • Added import re at file level.
  • Added @field_validator('phone', mode='after') with normalize_phone to sanitize phone strings using re.sub(r'(?!^\+)\D', '', v).
  • Ensures clean E.164 phone values are stored and indexed in MongoDB.

Testing Details

• Verified regular expression logic against international inputs (+1 234-567-8901 -> +12345678901).
• Confirmed backward compatibility and uniqueness constraint mapping with existing user model indices.

Checklist

• Canonical phone values are stored and indexed.
• Formatting variations cannot bypass uniqueness.
• All data sanitation logic is covered before persistence.

Closes #163

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mudabs]

Thank you, Moon, for adding backend phone normalization.

Please address these items before approval:

1. Run normalization before pattern validation. With mode='after', formatted values such as +1 234-567-8901 are rejected before normalization runs.
2. Apply the same normalization to UserUpdate and the profile update endpoint before duplicate checks and persistence.
3. Add collision detection for existing formatted records and document the migration and rollback plan. The current unique index only protects exact stored strings.
4. Add tests for formatted input, normalized duplicates, profile updates, canonical values, and invalid values.
5. Re-run the full CI workflow. The current CI run requires action and has no jobs, so only SonarCloud is verified.