Repository navigation
Conversation
mudabs
requested changes
Nov 13, 2026
mudabs
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, Olivia, for defining the manual health measurement contract and adding matching backend and frontend validation tests.
Please address these items before approval:
- Rebase the branch onto current main and rerun the full CI suite.
- Replace hardcoded English frontend validation messages with stable error keys or codes so consuming screens can localize them.
- Add a parity test or shared contract source to prevent backend and frontend metric rules from drifting.
- Confirm in the PR that this is intentionally contract-only and does not yet provide measurement persistence, API endpoints, or user-facing forms.
OliviaH05
force-pushed
the
feature/issue-172-health-metric-validation
branch
from
November 13, 2026 18:47
706f680 to
6a8da7d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary:
Creates a safe contract for manual health measurements by defining supported metrics, accepted units, and validation rules. This is intentionally contract-only and does not yet provide measurement persistence, API endpoints, or user-facing forms.
Changes Made:
Closes #172