Skip to content
This repository was archived by the owner on Dec 13, 2021. It is now read-only.
This repository was archived by the owner on Dec 13, 2021. It is now read-only.

LOW HANGING FRUIT: make goreportcard happy #150

Open

Description

@AkihiroSuda

goreportcard says A+ for Namazu v0.2.0, but there are still things we should do:

Component Score
go_vet 100%
gocyclo 98%
gofmt 98%
golint 41%
ineffassign 98%
license 100%
misspell 98%

gocyclo: 98%

namazu/nmz/cli/init.go
  Line 108: warning: cyclomatic complexity 22 of function _init() is high (> 15) (gocyclo)
namazu/nmz/explorepolicy/random/randompolicy.go
  Line 156: warning: cyclomatic complexity 17 of function (*Random).LoadConfig() is high (> 15) (gocyclo)

gofmt 98%

namazu/nmz/cli/tools/visualize.go
  Line 1: warning: file is not gofmted (gofmt)
namazu/nmz/signal/action_sched_procset_test.go
  Line 1: warning: file is not gofmted (gofmt)

golint 41%

...

ineffassign 98%

namazu/nmz/inspector/transceiver/resttransceiver.go
  Line 92: warning: err assigned and not used (ineffassign)
  Line 69: warning: err assigned and not used (ineffassign)
  Line 47: warning: err assigned and not used (ineffassign)
namazu/nmz/container/ns/boot.go
  Line 42: warning: err assigned and not used (ineffassign)

misspell 98%

namazu/nmz/endpoint/pb/pbendpoint.go
  Line 30: warning: 53:found "diferrent" a misspelling of "different" (misspell)
namazu/nmz/endpoint/pb/pbendpoint_test.go
  Line 107: warning: 55:found "diferrent" a misspelling of "different" (misspell)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions