config/oc: keep the neighbor config set through the API - #3593
Open
fdomain wants to merge 1 commit into
Open
Conversation
OverwriteNeighborConfigWithPeerGroup decides which neighbor fields to keep by asking viper which keys the operator wrote. That record lives in configuredFields, which is only filled while parsing a configuration file, so a neighbor added through the gRPC API has no entry: every key reports as unset and the peer group overwrote everything the caller passed. Fall back to treating a non-zero value as explicitly set when the neighbor has no config-file record. Neighbors read from a file keep the viper behavior, so a key configured to its zero value still wins over the peer group. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Florian Domain <f.domain@criteo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OverwriteNeighborConfigWithPeerGroup decides which neighbor fields to keep by asking viper which keys the operator wrote. That record lives in configuredFields, which is only filled while parsing a configuration file, so a neighbor added through the gRPC API has no entry: every key reports as unset and the peer group overwrote everything the caller passed.
Fall back to treating a non-zero value as explicitly set when the neighbor has no config-file record. Neighbors read from a file keep the viper behavior, so a key configured to its zero value still wins over the peer group.