metrics: fix the peer type values in the bgp_peer_type help text - #3592
Open
fdomain wants to merge 1 commit into
Open
metrics: fix the peer type values in the bgp_peer_type help text#3592fdomain wants to merge 1 commit into
fdomain wants to merge 1 commit into
Conversation
The help text and inline comment documented internal as 0 and external as 1, but the metric reports the api.PeerType protobuf enum, where internal is 1 and external is 2. Unspecified (0) is never emitted: toPeerType maps every non-external value to internal. Signed-off-by: Florian Domain <f.domain@criteo.com>
fdomain
force-pushed
the
fix-metric-help
branch
from
September 10, 2026 14:32
2222a9b to
8d15596
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help text and inline comment documented internal as 0 and external as 1, but the metric reports the api.PeerType protobuf enum, where internal is 1 and external is 2. Unspecified (0) is never emitted: toPeerType maps every non-external value to internal.