Skip to content

wizard: remove basic partitioning for image mode - #4748

Closed
lucasgarfield wants to merge 1 commit into
lucas/cockpit/7-rhel10-hostsfrom
lucas/cockpit/8-ui-tweaks
Closed

wizard: remove basic partitioning for image mode#4748
lucasgarfield wants to merge 1 commit into
lucas/cockpit/7-rhel10-hostsfrom
lucas/cockpit/8-ui-tweaks

Conversation

@lucasgarfield

Copy link
Copy Markdown
Collaborator

resolves #4710

Image mode images don't support customizations.filesystem, which
we use for basic partitioning. Remove it for Image Mode.


Stack created with GitHub Stacks CLIGive Feedback 💬

@lucasgarfield
lucasgarfield requested a review from a team as a code owner August 11, 2026 15:52
@lucasgarfield
lucasgarfield requested review from croissanne, ochosi and regexowl and removed request for a team August 11, 2026 15:52
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.10%. Comparing base (eba1d52) to head (999bc09).

Impacted file tree graph

@@                       Coverage Diff                        @@
##           lucas/cockpit/7-rhel10-hosts    #4748      +/-   ##
================================================================
- Coverage                         79.01%   74.10%   -4.91%     
================================================================
  Files                               265      262       -3     
  Lines                              7028     7006      -22     
  Branches                           2588     2553      -35     
================================================================
- Hits                               5553     5192     -361     
- Misses                             1376     1786     +410     
+ Partials                             99       28      -71     
Flag Coverage Δ
playwright ?
vitest 74.10% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...teps/FileSystem/components/FileSystemPartition.tsx 88.00% <100.00%> (-7.24%) ⬇️

... and 71 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba1d52...999bc09. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/8-ui-tweaks branch from ac121a5 to 34b4296 Compare August 12, 2026 11:53
@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/8-ui-tweaks branch from 34b4296 to e0b98bc Compare August 12, 2026 12:53
resolves #4710

Image mode images don't support customizations.filesystem, which
we use for basic partitioning. Remove it for Image Mode.
@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/8-ui-tweaks branch from e0b98bc to 999bc09 Compare August 13, 2026 15:23
@lucasgarfield

Copy link
Copy Markdown
Collaborator Author

Replaced by #4756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate basic partitioning support (HMS-11161)

1 participant