Skip to content

Wizard: replace local image builds with a coming-soon note (HMS-11160) - #4741

Closed
lucasgarfield wants to merge 2 commits into
mainfrom
lucas/cockpit/2-local-images
Closed

Wizard: replace local image builds with a coming-soon note (HMS-11160)#4741
lucasgarfield wants to merge 2 commits into
mainfrom
lucas/cockpit/2-local-images

Conversation

@lucasgarfield

@lucasgarfield lucasgarfield commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Local (custom) image builds aren't supported yet — on-prem image mode now shows a coming-soon empty state instead of a picker, and blocks navigation while it's selected.

  • Rename "Custom images" source card to "Local images"; drop the "No login" label
  • Replace the local image dropdown with a PatternFly empty state pointing at Cockpit Image Builder 10.4, with an image-builder CLI example for building local images in the meantime
  • Remove the official-vs-local dropdown logic: the podman distributions query for local images, registry-auth filtering of known references, and the ImageSelect typeahead machinery only the local dropdown used
  • Disable Next/Review and sidebar navigation while the local source is selected
  • Resolves Remove "Custom" images (HMS-11160) #4709

Stack created with GitHub Stacks CLIGive Feedback 💬

@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/2-local-images branch from ae57a46 to 5b4d87b Compare August 10, 2026 18:17
@lucasgarfield lucasgarfield changed the title lucas/cockpit/2 local images Wizard: replace local image builds with a coming-soon note (HMS-11160) Aug 10, 2026
@lucasgarfield
lucasgarfield marked this pull request as ready for review August 10, 2026 18:21
@lucasgarfield
lucasgarfield requested a review from a team as a code owner August 10, 2026 18:21

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The canNavigate computation in CreateImageWizard now has duplicated isBaseSettingsStep checks and an extra localImageSourceSelected gate; consider simplifying this condition so the base-step and local-image constraints are expressed once and are easier to reason about.
  • In LocalImageSource, the hard-coded references to Cockpit Image Builder 10.4 and the CLI example string would be easier to maintain (and potentially localize) if extracted into shared constants or a config, rather than being embedded directly in the component.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `canNavigate` computation in `CreateImageWizard` now has duplicated `isBaseSettingsStep` checks and an extra `localImageSourceSelected` gate; consider simplifying this condition so the base-step and local-image constraints are expressed once and are easier to reason about.
- In `LocalImageSource`, the hard-coded references to Cockpit Image Builder 10.4 and the CLI example string would be easier to maintain (and potentially localize) if extracted into shared constants or a config, rather than being embedded directly in the component.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

croissanne
croissanne previously approved these changes Aug 11, 2026

@croissanne croissanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of the mixed bootc distributions mock confused me at first, but ig it makes sense, like this is a scenario that would never happen, right?

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.20%. Comparing base (9944cbe) to head (cb9ad33).

Files with missing lines Patch % Lines
...omponents/ImageSourceSelect/OnPrem/ImageSelect.tsx 57.14% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
+ Coverage   77.90%   78.20%   +0.30%     
==========================================
  Files         264      264              
  Lines        7069     7021      -48     
  Branches     2597     2542      -55     
==========================================
- Hits         5507     5491      -16     
+ Misses       1465     1437      -28     
+ Partials       97       93       -4     
Flag Coverage Δ
playwright 59.07% <31.25%> (-0.87%) ⬇️
vitest 73.40% <85.71%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 84.46% <100.00%> (+0.25%) ⬆️
...reateImageWizard/components/CustomWizardFooter.tsx 70.27% <100.00%> (+14.71%) ⬆️
...mageOutput/components/ImageSourceSelect/Hosted.tsx 95.91% <100.00%> (ø)
.../components/ImageSourceSelect/ImageSourceError.tsx 100.00% <100.00%> (ø)
...ents/ImageSourceSelect/OnPrem/LocalImageSource.tsx 100.00% <100.00%> (ø)
...tput/components/ImageSourceSelect/OnPrem/index.tsx 75.00% <100.00%> (+25.00%) ⬆️
...omponents/ImageSourceSelect/OnPrem/ImageSelect.tsx 60.86% <57.14%> (-1.14%) ⬇️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9944cbe...cb9ad33. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@croissanne
croissanne force-pushed the lucas/cockpit/2-local-images branch from 5cab56d to 24afc25 Compare August 11, 2026 12:39
Base automatically changed from lucas/cockpit/1-dev-registry to main August 11, 2026 13:46
@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/2-local-images branch from 24afc25 to 58b940a Compare August 11, 2026 13:46
@lucasgarfield

lucasgarfield commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Getting rid of the mixed bootc distributions mock confused me at first, but ig it makes sense, like this is a scenario that would never happen, right?

Exactly - we're only going to be supporting RHEL, and even then we're only supporting a small set of images (the ones available on catalog.redhat.com for kvm, aws, iso, and the base container to use as the iso payload).

@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/2-local-images branch from 58b940a to 5b4d87b Compare August 11, 2026 15:51
@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/2-local-images branch from 5b4d87b to 27dc673 Compare August 12, 2026 11:53
@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/2-local-images branch from 27dc673 to caf7b0a Compare August 12, 2026 12:53
@lucasgarfield
lucasgarfield added this pull request to the merge queue Aug 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 13, 2026
Local (custom) image builds are not supported in this release. Rename
the "Custom images" source card to "Local images", drop its "No
login" label, and replace the local image dropdown with a small empty
state noting that support lands in Cockpit Image Builder 10.4,
alongside an image-builder CLI example for building local images in
the meantime. The empty state follows PatternFly's guidance for a
wizard pane with nothing to show; the gray rocket icon is their icon
mapping for a feature that cannot be used yet.

This removes the official-vs-local dropdown logic: the podman
distributions query for local images, the registry-auth-based filtering
of known references, and the typeahead machinery in ImageSelect that
only the local dropdown used. The rewritten tests don't cover the
official image dropdown interactions: the dropdown is on its way out
as a selection mechanism, and the tests that replace it arrive with
that change.

Resolves #4709
The local image source only shows a coming-soon note, so disable the
Next and Review image buttons and the sidebar navigation while it is
selected.
@lucasgarfield
lucasgarfield force-pushed the lucas/cockpit/2-local-images branch from caf7b0a to cb9ad33 Compare August 13, 2026 15:23
@lucasgarfield

Copy link
Copy Markdown
Collaborator Author

Replaced by #4756 - was approved but CI failing so will just let #4756 get in instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "Custom" images (HMS-11160)

2 participants