Wizard: replace local image builds with a coming-soon note (HMS-11160) - #4741
Wizard: replace local image builds with a coming-soon note (HMS-11160)#4741lucasgarfield wants to merge 2 commits into
Conversation
ae57a46 to
5b4d87b
Compare
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
canNavigatecomputation inCreateImageWizardnow has duplicatedisBaseSettingsStepchecks and an extralocalImageSourceSelectedgate; consider simplifying this condition so the base-step and local-image constraints are expressed once and are easier to reason about. - In
LocalImageSource, the hard-coded references to Cockpit Image Builder 10.4 and the CLI example string would be easier to maintain (and potentially localize) if extracted into shared constants or a config, rather than being embedded directly in the component.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `canNavigate` computation in `CreateImageWizard` now has duplicated `isBaseSettingsStep` checks and an extra `localImageSourceSelected` gate; consider simplifying this condition so the base-step and local-image constraints are expressed once and are easier to reason about.
- In `LocalImageSource`, the hard-coded references to Cockpit Image Builder 10.4 and the CLI example string would be easier to maintain (and potentially localize) if extracted into shared constants or a config, rather than being embedded directly in the component.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
croissanne
left a comment
There was a problem hiding this comment.
Getting rid of the mixed bootc distributions mock confused me at first, but ig it makes sense, like this is a scenario that would never happen, right?
5b4d87b to
5cab56d
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4741 +/- ##
==========================================
+ Coverage 77.90% 78.20% +0.30%
==========================================
Files 264 264
Lines 7069 7021 -48
Branches 2597 2542 -55
==========================================
- Hits 5507 5491 -16
+ Misses 1465 1437 -28
+ Partials 97 93 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
5cab56d to
24afc25
Compare
24afc25 to
58b940a
Compare
Exactly - we're only going to be supporting RHEL, and even then we're only supporting a small set of images (the ones available on catalog.redhat.com for kvm, aws, iso, and the base container to use as the iso payload). |
58b940a to
5b4d87b
Compare
5b4d87b to
27dc673
Compare
27dc673 to
caf7b0a
Compare
Local (custom) image builds are not supported in this release. Rename the "Custom images" source card to "Local images", drop its "No login" label, and replace the local image dropdown with a small empty state noting that support lands in Cockpit Image Builder 10.4, alongside an image-builder CLI example for building local images in the meantime. The empty state follows PatternFly's guidance for a wizard pane with nothing to show; the gray rocket icon is their icon mapping for a feature that cannot be used yet. This removes the official-vs-local dropdown logic: the podman distributions query for local images, the registry-auth-based filtering of known references, and the typeahead machinery in ImageSelect that only the local dropdown used. The rewritten tests don't cover the official image dropdown interactions: the dropdown is on its way out as a selection mechanism, and the tests that replace it arrive with that change. Resolves #4709
The local image source only shows a coming-soon note, so disable the Next and Review image buttons and the sidebar navigation while it is selected.
caf7b0a to
cb9ad33
Compare
Local (custom) image builds aren't supported yet — on-prem image mode now shows a coming-soon empty state instead of a picker, and blocks navigation while it's selected.
image-builderCLI example for building local images in the meantimeImageSelecttypeahead machinery only the local dropdown usedStack created with GitHub Stacks CLI • Give Feedback 💬