Wizard: let the target radios drive the official image (HMS-11166)

[lucasgarfield]

Target environment radios now fully determine the selected official image; the dropdown is replaced by a read-only, copyable container reference.

• Add an AWS (ec2) variant of the official images alongside the guest image, published under a shared name
• On-prem image mode always offers the official images' output types as target radios, whether or not an image is selected yet
• Add a resolveOfficialImage listener on changeImageTypes (guarded by the IS_ON_PREMISE build constant) resolving image source + distribution from the picked radio
• Replace the dropdown with read-only ContainerSection: copyable container reference plus human-readable image name; shows a hint before a target is picked
• Collapse the field, pull button, existence check, and pull validation into ContainerSection; delete ImageSelect
• Drop the now-unused imageSource narrowing from the derived distributions endpoint and selectImageSourceFilter
• Resolves Add aws (HMS-11166) #4715, Disable Image Mode for non-RHEL hosts #4721

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[sourcery-ai]

Hey - I've found 2 issues

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="src/Components/CreateImageWizard/steps/ImageOutput/components/ImageSourceSelect/OnPrem/ContainerSection.tsx" line_range="89-91" />
<code_context>
+
+  // Local images can be removed outside the wizard (e.g. podman rmi),
+  // so bypass the cache and re-check whenever this section mounts.
+  const { data: imageExists } = useGetImageExistsQuery(
+    { reference: reference! },
+    { skip: !reference, refetchOnMountOrArgChange: true },
+  );
+
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Avoid using a non-null assertion for reference when the hook is skipped

`reference!` is unsafe here: `reference` is allowed to be undefined and the query is already guarded via `skip: !reference`. The non-null assertion hides that possibility and makes future refactors more error-prone. Prefer either:

- Passing a safe fallback (e.g. `reference ?? ''`), or
- Only creating the args when `reference` is truthy (e.g. `reference ? { reference } : skipToken`).

This keeps the types accurate and avoids relying on `!` in the hook args.

Suggested implementation:

```typescript
  // Local images can be removed outside the wizard (e.g. podman rmi),
  // so bypass the cache and re-check whenever this section mounts.
+  const { data: imageExists } = useGetImageExistsQuery(
+    reference ? { reference } : skipToken,
+    { refetchOnMountOrArgChange: true },
+  );
+

```

You also need to ensure `skipToken` is imported in this file. If not already present, add:

```ts
import { skipToken } from '@reduxjs/toolkit/query';
```

near the other imports (or from the specific RTK Query entrypoint your project uses, such as `@reduxjs/toolkit/query/react` if that's the convention in this codebase).
</issue_to_address>

### Comment 2
<location path="src/store/slices/wizard/listeners.ts" line_range="121-125" />
<code_context>
+    return;
+  }
+
+  const imageTypes = selectImageTypes(state);
+  if (imageTypes.length === 0) {
+    return;
+  }
+  const targetType = imageTypes[0];
+
+  const currentRef = selectImageSource(state);
</code_context>
<issue_to_address>
**suggestion:** Clarify or guard the assumption that only a single image type is relevant

`resolveOfficialImage` assumes `selectImageTypes` returns exactly one type (`const targetType = imageTypes[0];`). This matches the current single-select UI, but if multi-select is ever introduced, we’ll silently ignore additional types and always use the first. Please either enforce the single-select assumption (e.g., bail out or handle explicitly when `imageTypes.length > 1`) or add a clear guard/assertion so future changes don’t accidentally rely on the first element arbitrarily.

```suggestion
  const imageTypes = selectImageTypes(state);
  // This logic assumes that exactly one image type is selected.
  // If the UI is ever extended to support multi-select, this guard
  // should be revisited so we don't arbitrarily pick the first type.
  if (imageTypes.length !== 1) {
    return;
  }
  const [targetType] = imageTypes;
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Avoid using a non-null assertion for reference when the hook is skipped

reference! is unsafe here: reference is allowed to be undefined and the query is already guarded via skip: !reference. The non-null assertion hides that possibility and makes future refactors more error-prone. Prefer either:

• Passing a safe fallback (e.g. reference ?? ''), or
• Only creating the args when reference is truthy (e.g. reference ? { reference } : skipToken).

This keeps the types accurate and avoids relying on ! in the hook args.

Suggested implementation:

  // Local images can be removed outside the wizard (e.g. podman rmi),
  // so bypass the cache and re-check whenever this section mounts.
+  const { data: imageExists } = useGetImageExistsQuery(
+    reference ? { reference } : skipToken,
+    { refetchOnMountOrArgChange: true },
+  );
+

You also need to ensure skipToken is imported in this file. If not already present, add:

import { skipToken } from '@reduxjs/toolkit/query';

near the other imports (or from the specific RTK Query entrypoint your project uses, such as @reduxjs/toolkit/query/react if that's the convention in this codebase).

[sourcery-ai]

suggestion: Clarify or guard the assumption that only a single image type is relevant

resolveOfficialImage assumes selectImageTypes returns exactly one type (const targetType = imageTypes[0];). This matches the current single-select UI, but if multi-select is ever introduced, we’ll silently ignore additional types and always use the first. Please either enforce the single-select assumption (e.g., bail out or handle explicitly when imageTypes.length > 1) or add a clear guard/assertion so future changes don’t accidentally rely on the first element arbitrarily.

Suggested change

	const imageTypes = selectImageTypes(state);
	if (imageTypes.length === 0) {
	return;
	}
	const targetType = imageTypes[0];
	const imageTypes = selectImageTypes(state);
	// This logic assumes that exactly one image type is selected.
	// If the UI is ever extended to support multi-select, this guard
	// should be revisited so we don't arbitrarily pick the first type.
	if (imageTypes.length !== 1) {
	return;
	}
	const [targetType] = imageTypes;

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[codecov]

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.22%. Comparing base (fdc321a) to head (1b3b16f).

Files with missing lines	Patch %	Lines
...ents/ImageSourceSelect/OnPrem/ContainerSection.tsx	93.93%	1 Missing and 1 partial ⚠️

@@                         Coverage Diff                         @@
##           lucas/cockpit/3-official-images    #4737      +/-   ##
===================================================================
+ Coverage                            78.98%   79.22%   +0.24%     
===================================================================
  Files                                  264      264              
  Lines                                 7033     7004      -29     
  Branches                              2548     2576      +28     
===================================================================
- Hits                                  5555     5549       -6     
+ Misses                                1381     1358      -23     
  Partials                                97       97              

Flag	Coverage Δ
playwright	60.70% <23.52%> (+0.91%)	⬆️
vitest	74.03% <95.45%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/ImageSourceSelect/OnPrem/OfficialImageSource.tsx	85.71% <100.00%> (+7.93%)	⬆️
...steps/ImageOutput/components/TargetEnvironment.tsx	87.25% <100.00%> (+1.08%)	⬆️
...ents/ImageSourceSelect/OnPrem/ContainerSection.tsx	93.93% <93.93%> (ø)

... and 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc321a...1b3b16f. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lucasgarfield]

Replaced by #4756