Skip to content

Wizard: always enable Create/Save buttons on Review step (HMS-10658) - #4627

Open
mgold1234 wants to merge 1 commit into
osbuild:mainfrom
mgold1234:review-footer-always-enabled
Open

Wizard: always enable Create/Save buttons on Review step (HMS-10658)#4627
mgold1234 wants to merge 1 commit into
osbuild:mainfrom
mgold1234:review-footer-always-enabled

Wizard: always enable navigation and action buttons (HMS-10658)

f892162
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 26, 2026 in 0s

78.97% (-0.16%) compared to 54d123c

View this Pull Request on Codecov

78.97% (-0.16%) compared to 54d123c

Details

Codecov Report

❌ Patch coverage is 68.83117% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.97%. Comparing base (54d123c) to head (f892162).

Files with missing lines Patch % Lines
...reateImageWizard/components/ReviewWizardFooter.tsx 28.57% 14 Missing and 1 partial ⚠️
...ImageWizard/steps/Review/Footer/CreateDropdown.tsx 25.00% 2 Missing and 1 partial ⚠️
...teImageWizard/steps/Review/Footer/EditDropdown.tsx 25.00% 2 Missing and 1 partial ⚠️
.../CreateImageWizard/utilities/scrollToFirstError.ts 0.00% 2 Missing ⚠️
...ents/CreateImageWizard/utilities/useValidation.tsx 97.05% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4627      +/-   ##
==========================================
- Coverage   79.13%   78.97%   -0.16%     
==========================================
  Files         265      266       +1     
  Lines        7015     7059      +44     
  Branches     2551     2603      +52     
==========================================
+ Hits         5551     5575      +24     
- Misses       1368     1384      +16     
- Partials       96      100       +4     
Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 84.31% <100.00%> (ø)
...reateImageWizard/components/CustomWizardFooter.tsx 60.00% <100.00%> (ø)
...eWizard/steps/Review/Footer/shouldDisableAction.ts 100.00% <100.00%> (ø)
...teps/Review/components/shared/ReviewCardHeader.tsx 55.55% <ø> (ø)
...ents/CreateImageWizard/utilities/useValidation.tsx 86.90% <97.05%> (+0.13%) ⬆️
.../CreateImageWizard/utilities/scrollToFirstError.ts 10.00% <0.00%> (-1.12%) ⬇️
...ImageWizard/steps/Review/Footer/CreateDropdown.tsx 49.18% <25.00%> (-1.70%) ⬇️
...teImageWizard/steps/Review/Footer/EditDropdown.tsx 40.90% <25.00%> (-1.60%) ⬇️
...reateImageWizard/components/ReviewWizardFooter.tsx 57.44% <28.57%> (-24.70%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d123c...f892162. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.