Support reading HDF5 files from TAR file.#5132
Open
pnorbert wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@eisenhauer This is for your review because I refactored the remote connection prep code from BP5Reader to Remote. Also, I couldn't test any of this with the xrootd connection only with the remote server. Let's merge only once we are sure it works with xrootd too. |
Member
|
I'll take a look. The sanitizers seem to be broken, so nothing is passing currently. |
Refactored the remote connection preparation code from BP5Reader into Remote functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the remote connection preparation code from BP5Reader into Remote functions.