fix(ui): honor explicit JSON log levels - #629
Kudala Bharani Kumar Reddy (kudala-bharani) wants to merge 1 commit into
Conversation
Signed-off-by: kudala-bharani <bunnykudala@gmail.com>
|
Kudala Bharani Kumar Reddy (@kudala-bharani) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
|
Kudala Bharani Kumar Reddy (@kudala-bharani) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sertaç Özercan (sozercan)
left a comment
There was a problem hiding this comment.
LGTM
Kudala Bharani Kumar Reddy (@kudala-bharani) please sign the CLA when you get a chance
Fixes #624.
JSON log lines now use their explicit
levelfor coloring, so an info message such as{"level":"info","msg":"error count is zero"}no longer appears red. Recognized levels are case-insensitive, andwarningmaps towarn.Plain text, malformed JSON, and missing or unsupported levels keep the existing text-based fallback. No dependencies or streaming behavior changed.
Added 20 regression cases covering conflicting message text, mixed-case levels, and fallback behavior. Six cases fail before the fix and pass afterward.
Verification:
node node_modules/vitest/vitest.mjs run).bun run lintandbun run build: passed (Bun 1.3.13).The initial full-suite run on Node 25.9.0 hit 13 unrelated chat-store failures because its global
localStoragelackedsetItem. They pass on Node 24 without changing the chat code.