fix(node-servant): add system:nodes group to yurt-hub-multiplexer ClusterRoleBinding - #2729
Open
Pragnasri-363 wants to merge 1 commit into
Open
fix(node-servant): add system:nodes group to yurt-hub-multiplexer ClusterRoleBinding#2729Pragnasri-363 wants to merge 1 commit into
Pragnasri-363 wants to merge 1 commit into
Conversation
…sterRoleBinding,fixes (openyurtio#2716)
|
Author
|
Following up on my own PR: I tested this fix directly against a live cluster (manually applying the ClusterRoleBinding change) and confirmed it does not actually resolve the issue ,check my updated comment on #2716 for the full explanation. Root cause is deeper than RBAC: Kubernetes' NodeRestriction admission controller blocks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes node-servant conversion failing with "context deadline exceeded" during label-driven edge node conversion. Root cause: YurtHub authenticates as
system:node:<name>, but theyurt-hub-multiplexerClusterRole is bound only to theopenyurt:multiplexergroup. Since node identities are never added to this group, YurtHub is being denied access to ConfigMaps and NodePool resources it needs at startup, causing it to never reach a ready state, node-servant then times out waiting for YurtHub's readiness signal.This PR adds the
system:nodesgroup (which all node identities automatically belong to) to theyurt-hub-multiplexer-bindingClusterRoleBinding as part of the conversion process. This is done once, idempotently, covering all current and future nodes — rather than adding individual per-node entries, which would grow unboundedly at scale.Which issue(s) this PR fixes:
Fixes #2716
Special notes for your reviewer:
This adds a
system:nodesGroup subject rather than per-node User entries, to avoid the ClusterRoleBinding's subject list growing unboundedly as nodes are converted. Usesretry.RetryOnConflictto handle concurrent conversions safely.Does this PR introduce a user-facing change?
other Note