fix(yurt-manager): resolve endpointslice patch collision by using Uni… - #2719
Open
Rickydama3 wants to merge 1 commit into
Open
fix(yurt-manager): resolve endpointslice patch collision by using Uni…#2719Rickydama3 wants to merge 1 commit into
Rickydama3 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…xNano timestamp
What type of PR is this?
What this PR does / why we need it:
This PR resolves a race condition in the
servicetopologycontroller that caused topology annotation changes to appear inert at the edge.Previously,
UpdateTriggerAnnotationsutilizedtime.Now().Unix()to generate theopenyurt.io/update-triggerpatch. Because this only resolves to the second, rapid updates to multiple Services within the same 1-second window resulted in identical patch payloads. The Kubernetes API server dropped these identical patches due to idempotency, meaning no watch events were propagated toyurthub.By upgrading the timestamp generation to
time.Now().UnixNano(), every patch is guaranteed to mutate the object state, ensuring reliable event propagation to the edge nodes.Which issue(s) this PR fixes:
Fixes #2612
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note