nfs-kernel-server: correct libsqlite3 dependency#30058
Conversation
lsqlite3 is for LUA bindings, libsqlite3 is the actual lib Signed-off-by: Jan Klos <jan@klos.xyz>
Formality Check: FailedWe completed the verification flow. Please review the formatting overview logs below. 🛑 CRITICAL ERRORS
Tip Do not close this pull request to make corrections. Instead, modify your existing commits (e.g. Something broken? Consider reporting an issue. |
|
Eh, shall I change the indentation of the whole makefile? |
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The dependency correction is accurate: lsqlite3 (lang/lua/lua-lsqlite3) is the Lua binding for SQLite3, while libsqlite3 (libs/sqlite3) is the actual library — so depending on +libsqlite3 is correct. The PKG_RELEASE bump and commit message are appropriate. One inline note on the failing FormalityCheck / OpenWrt Makefiles check.
Generated by Claude Code
| CATEGORY:=Network | ||
| SUBMENU:=Filesystem | ||
| DEPENDS:=+libblkid +libuuid +libtirpc +lsqlite3 +libxml2 +libnl | ||
| DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl |
There was a problem hiding this comment.
The FormalityCheck / OpenWrt Makefiles check is failing on this line:
Makefile line 'DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl'
inside 'Package/nfs-kernel-server/Default' must be indented with exactly 2 spaces
Because you touched this line, the formality check requires it to be indented with 2 spaces instead of a tab. To answer your question in the thread: you do not need to reindent the whole Makefile — converting just this modified line is enough to make the check pass.
| DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl | |
| DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl |
Generated by Claude Code
lsqlite3 is for LUA bindings, libsqlite3 is the actual lib
📦 Package Details
Maintainer: @graysky2
Description:
This is just a minor thing as the LUA bindings depend on the lib itself, so this just removes a useless dependency.
🧪 Run Testing Details
✅ Formalities