Skip to content

nfs-kernel-server: correct libsqlite3 dependency#30058

Open
drujd wants to merge 1 commit into
openwrt:masterfrom
drujd:nfs-kernel-server-libsqlite_fix
Open

nfs-kernel-server: correct libsqlite3 dependency#30058
drujd wants to merge 1 commit into
openwrt:masterfrom
drujd:nfs-kernel-server-libsqlite_fix

Conversation

@drujd

@drujd drujd commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

lsqlite3 is for LUA bindings, libsqlite3 is the actual lib

📦 Package Details

Maintainer: @graysky2

Description:
This is just a minor thing as the LUA bindings depend on the lib itself, so this just removes a useless dependency.


🧪 Run Testing Details

  • OpenWrt Version: master/SNAPSHOT
  • OpenWrt Target/Subtarget: i386/x64
  • OpenWrt Device: AMD Ryzen-based PC serving as my router

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

lsqlite3 is for LUA bindings, libsqlite3 is the actual lib

Signed-off-by: Jan Klos <jan@klos.xyz>
@openwrt

openwrt Bot commented Jul 20, 2026

Copy link
Copy Markdown

Formality Check: Failed

We completed the verification flow. Please review the formatting overview logs below.

🛑 CRITICAL ERRORS

Commit ae76776 - nfs-kernel-server: correct libsqlite3 dependency:

  • Makefile line 'DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl' inside 'Package/nfs-kernel-server/Default' must be indented with exactly 2 spaces

Tip

Do not close this pull request to make corrections. Instead, modify your existing commits (e.g. git commit --amend) and update the branch using git push --force-with-lease --force-if-includes. The checks will re-run automatically.


Something broken? Consider reporting an issue.
Running version c46a507 deployed on 2026-07-20 13:23:59 CEST

@drujd

drujd commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Eh, shall I change the indentation of the whole makefile?

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.

The dependency correction is accurate: lsqlite3 (lang/lua/lua-lsqlite3) is the Lua binding for SQLite3, while libsqlite3 (libs/sqlite3) is the actual library — so depending on +libsqlite3 is correct. The PKG_RELEASE bump and commit message are appropriate. One inline note on the failing FormalityCheck / OpenWrt Makefiles check.


Generated by Claude Code

CATEGORY:=Network
SUBMENU:=Filesystem
DEPENDS:=+libblkid +libuuid +libtirpc +lsqlite3 +libxml2 +libnl
DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FormalityCheck / OpenWrt Makefiles check is failing on this line:

Makefile line 'DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl'
inside 'Package/nfs-kernel-server/Default' must be indented with exactly 2 spaces

Because you touched this line, the formality check requires it to be indented with 2 spaces instead of a tab. To answer your question in the thread: you do not need to reindent the whole Makefile — converting just this modified line is enough to make the check pass.

Suggested change
DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl
DEPENDS:=+libblkid +libuuid +libtirpc +libsqlite3 +libxml2 +libnl

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants