zabbix: bring agent, server, and proxy to parity#30026
zabbix: bring agent, server, and proxy to parity#30026danielfdickinson wants to merge 4 commits into
Conversation
This is the upstream recommendation, and fits with our separation of agent and server. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
Tweak the agentd and server patch configurations and bring agentd and server confgurations to parity. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
11826d3 to
d4841fd
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 4 new commits; commit messages match their changes. One inline issue on the zabbix-agentd-basic conffiles/postinst references.
Generated by Claude Code
d4841fd to
5be382f
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 2 new commits; no new issues found. The previously flagged zabbix-agentd-basic conffiles/postinst references now correctly point to Package/zabbix-agentd/* (hyphen), matching the actual defines.
Generated by Claude Code
* Genericize zabbix_server initscript. * Add shellcheck overrides where needed. * Add a 'never_root' config option (default true) that determines whether server starts as an unprivileged user or starts as root and drops to an unprivileged user (unless config is changed so it always runs as root). * Bring zabbix_agentd initscript to parity with zabbix_server for the initscript and configuration. * Tweak Makefile to reduce repetition Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
* Add config file patch for proxy * Add initscript for proxy * Update Makefile and support files to bring proxy to parity with agentd and server. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
5be382f to
fb2e609
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 2 new commits; no new issues found. Since the last review the only change is introducing a UCI_CONFIG=/etc/config/${NAME} variable in the three init scripts and using it in the "service not enabled" log message; the substitution is consistent and all /etc/config/$NAME references were updated.
Generated by Claude Code
📦 Package Details
Maintainer: @danielfdickinson
Description:
Splits out the main set of changes from #30010 because it is cleaner / better separation of concerns.
fits with our seperation of agent and server.
server confgurations to parity.
whether server starts as an unprivileged user or starts as root and
drops to an unprivileged user (unless config is changed so it always
runs as root).
initscript and configuration.
agentd and server.
and (after split)
✅ Formalities
If your PR contains a patch:
git amN/A: OpenWrt-specific configuration tweaks