prometheus-node-exporter-lua: add dhcp-leases exporter#30006
Conversation
ced76f0 to
e4bf805
Compare
|
I think there's a bug in the bot: things look pretty consistent? |
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
prometheus-node-exporter-lua: add dhcp-leases exporter— the commit message/PR body say the collector "expose[s] device type", but the code actually emits avendorlabel populated from ufp'sfingerprintubus object (withufp-neighproviding the OUI/vendor database). Consider aligning the wording with thevendorlabel the collector actually produces.
The exporter itself looks correct: it degrades gracefully when ubus/ufp is unavailable (conn and get_vendor(...) or "", pcall around the ubus call), closes both the file and ubus connection, and upper-cases the MAC consistently with the existing uci_dhcp_host collector.
Generated by Claude Code
Bot says: |
e4bf805 to
2b12392
Compare
Add a new collector to expose DHCP leases. It optionally depends on ufp-neigh to emit a 'vendor' label. This is populated from ufp's fingerprint ubus object, with ufp-neigh providing the OUI/vendor database. Signed-off-by: Stephen Finucane <stephen@that.guru>
2b12392 to
e7a2e91
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The dropped +libubus-lua dependency is safe: the base prometheus-node-exporter-lua package already lists it in DEPENDS, so it is still pulled in transitively (same pattern as the dawn collector). The amended commit message now correctly describes the vendor label, resolving the earlier commit-check note.
Generated by Claude Code
Add a new collector to expose DHCP leases. It optionally depends on
ufp-neigh to expose device type.
Signed-off-by: Stephen Finucane stephen@that.guru
📦 Package Details
Maintainer: @champtar
(You can find this by checking the history of the package
Makefile.)Description:
Add new collector for the DHCP leases. This is useful for a system status dashboard.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.