gpgme: use target staging gpgrt-config#29982
Open
fwerkor wants to merge 1 commit into
Open
Conversation
fwerkor
force-pushed
the
gpgme-pin-target-gpgrt-config
branch
from
July 12, 2026 11:18
108b721 to
4c58ca9
Compare
openwrt-ai
reviewed
Jul 13, 2026
fwerkor
force-pushed
the
gpgme-pin-target-gpgrt-config
branch
from
July 15, 2026 14:09
308e3a9 to
f9ff0f2
Compare
openwrt-ai
reviewed
Jul 16, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit. One inline note on the missing PKG_RELEASE bump for this build-affecting change; the configure pinning itself matches libassuan and looks correct.
Generated by Claude Code
fwerkor
force-pushed
the
gpgme-pin-target-gpgrt-config
branch
from
July 16, 2026 07:31
457354d to
b94e783
Compare
github-actions
Bot
force-pushed
the
gpgme-pin-target-gpgrt-config
branch
from
July 16, 2026 07:45
68b05b1 to
4680274
Compare
fwerkor
marked this pull request as draft
July 16, 2026 07:45
github-actions
Bot
force-pushed
the
gpgme-pin-target-gpgrt-config
branch
from
July 16, 2026 07:48
ca6660d to
509778a
Compare
gpgme's configure script looks up gpgrt-config through PATH and may select the host copy. This injects host include and library paths into cross builds, causing glibc headers to be mixed with the target musl headers. Pin gpgrt-config to the target staging directory, matching libassuan, and bump PKG_RELEASE to 3. Signed-off-by: Cao Yuhang <caoyuhang@fwerkor.com>
github-actions
Bot
force-pushed
the
gpgme-pin-target-gpgrt-config
branch
from
July 16, 2026 07:49
3a725f5 to
6a37e36
Compare
fwerkor
marked this pull request as ready for review
July 16, 2026 07:50
fwerkor
marked this pull request as draft
July 16, 2026 07:53
fwerkor
marked this pull request as ready for review
July 16, 2026 08:06
openwrt-ai
reviewed
Jul 17, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found. The PKG_RELEASE bump to 3 addresses the prior note, and the commit message now matches the diff.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @dangowrt
(You can find this by checking the history of the package
Makefile.)Description:
gpgme's configure script looks upgpgrt-configthroughPATH. When the host tool is installed, configure may select the host copy and inject host paths such as/usr/includeand/usr/libinto the cross build, mixing glibc headers with the target musl headers.This change pins the configure lookup to the target staging tool:
This matches the existing handling in
libassuan.PKG_RELEASEis also incremented from 2 to 3.Related: #19880
The fix was validated in an OpenWrt-derived x86_64 full image build: configure no longer selected the host
gpgrt-config, andgpgmecompiled successfully.🧪 Run Testing Details
masterx86/64Not run on upstream master; issue reproduced in an OpenWrt-derived x86_64 build✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.