-
Notifications
You must be signed in to change notification settings - Fork 1
CORE-2611 Changed prerendering to vCPU scaling, give each task at least 2 vCPU (1 per thread) #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
2d0e67a
8a3f9bc
d81289b
4771b20
a65e43d
cc7a61d
7344f86
86113a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,10 +60,10 @@ import { RELEASE_ID, WORK_REGION, BUCKET_NAME, BUCKET_REGION, PUBLIC_URL } from | |
| const MAX_CONCURRENT_BOOKS = 5; | ||
|
|
||
| // Number of concurrent prerender tasks to run | ||
| const DESIRED_TASK_COUNT = 32; | ||
| const DESIRED_TASK_COUNT = 16; | ||
|
|
||
| // Total fleet memory capacity in MiB (must equal DESIRED_TASK_COUNT * 4096) | ||
| const TOTAL_MEMORY_MIB = DESIRED_TASK_COUNT * 4096; | ||
| // Total fleet vCPU capacity (must equal DESIRED_TASK_COUNT * 2) | ||
| const TOTAL_VCPU_COUNT = DESIRED_TASK_COUNT * 2; | ||
|
Dantemss marked this conversation as resolved.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 32 vCPU seems to make the prerendering finish in a timely manner, about 25 minutes when everything goes well. I decided I wanted 16 tasks (containers) with 2 vCPU each, and each task spawns 2 threads so they can use both vCPU. This is mostly based on wanting things to run on at least 1 full Intel core. Maybe 3 or 4 threads could work better, but determining that would require some actual benchmarking. |
||
|
|
||
| // Retry EPROTO errors in requests this many times | ||
| const MAX_ATTEMPTS = 5; | ||
|
|
@@ -200,8 +200,8 @@ async function createWorkersStack() { | |
| ParameterValue: RELEASE_ID, | ||
| }, | ||
| { | ||
| ParameterKey: 'TotalMemoryMiB', | ||
| ParameterValue: TOTAL_MEMORY_MIB.toString(), | ||
| ParameterKey: 'TotalVCpuCount', | ||
| ParameterValue: TOTAL_VCPU_COUNT.toString(), | ||
| }, | ||
| { | ||
| ParameterKey: 'ValidUntil', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.