CCSINTL-3575: Short desc CQA fixes#114225
Conversation
|
@abrennan89: This pull request references CCSINTL-3575 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Fri Jun 26 15:55:29 - Prow CI generated the docs preview: |
|
@abrennan89: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
sjhala-ccs
left a comment
There was a problem hiding this comment.
Just one nit, otherwise LGTM
|
|
||
| [role="_abstract"] | ||
| As an OpenShift administrator, you can create or configure a physical network in the {product-title} web console without using the node network configuration policy (NNCP) page. The *Physical networks* page is available when the NMState console plugin is installed. When you use the *Physical networks* page in the web console, the NNCP is generated automatically. If you need more flexibility or require complex settings, use the NNCP page. | ||
| As an {product-title} administrator, you can create or configure a physical network in the {product-title} web console without using the node network configuration policy (NNCP) page. |
There was a problem hiding this comment.
I am not sure if "node network configuration policy (NNCP)" is the name of the page in the web console, but the name should be in bold formatting
|
|
||
| [NOTE] | ||
| ==== | ||
| The *Physical networks* page is available when the NMState console plugin is installed. When you use the *Physical networks* page in the web console, the NNCP is generated automatically. If you need more flexibility or require complex settings, use the NNCP page. |
There was a problem hiding this comment.
s/NNCP/<actual_page_name_in_bold>
|
Since this is high priority and we have a deadline for 6/30, I will merge this as is and we can check on the page names etc during the next phase for JTBD |
|
/cherrypick enterprise-5.0 |
|
/cherrypick enterprise-4.22 |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
@abrennan89: #114225 failed to apply on top of branch "enterprise-5.0": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@abrennan89: new pull request created: #114244 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@abrennan89: #114225 failed to apply on top of branch "enterprise-4.21": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@abrennan89: #114225 failed to apply on top of branch "enterprise-4.20": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.20+
Issue:
CCSINTL-3575
Link to docs preview:
QE review:
n/a - editing only for this PR
Additional information: