refactor: decouple resource pairing into hook

[matejvasek]

Summary

• Introduce ClusterFunction paired type in useClusterService, moving ksvc-to-deployment matching logic out of FunctionsListPage into the hook
• Simplify page enrichment to a name-based lookup on pre-paired ClusterFunction objects
• Rename FunctionTableItem.deployment to mainResource (it holds the ksvc, not a Deployment)

Test plan

• yarn ci passes (147 tests, lint clean, build succeeds)
• Verify FunctionCreatePage still works (only uses generateKubeconfig, unchanged)
• Manual smoke test on cluster: list page shows correct status, replicas, URL for deployed functions

🤖 Generated with Claude Code

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@matejvasek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Cragsmann]

typecasting should be avoided here

[matejvasek]

Agree, but this is pre-existing issue. I would prefer to fix it in some other PR.

[matejvasek]

Also I am not sure about clean fix. Following is not much better IMO.

diff --git a/src/pages/function-list/components/FunctionTable.tsx b/src/pages/function-list/components/FunctionTable.tsx
index c0c4b07..3a92d39 100644
--- a/src/pages/function-list/components/FunctionTable.tsx
+++ b/src/pages/function-list/components/FunctionTable.tsx
@@ -88,7 +88,11 @@ export function FunctionTable({
                   />
                 </ActionListItem>
                 <ActionListItem>
-                  <DeleteActionButton mainResource={fn.mainResource} />
+                  {fn.mainResource ? (
+                    <DeleteActionButton mainResource={fn.mainResource} />
+                  ) : (
+                    <DisabledDeleteButton />
+                  )}
                 </ActionListItem>
               </ActionList>
             </Td>
@@ -133,21 +137,20 @@ function UrlCell({ url }: { url?: string }) {
   );
 }
 
-function DeleteActionButton({ mainResource }: { mainResource?: K8sResourceKind }) {
+function DisabledDeleteButton() {
   const { t } = useTranslation('plugin__console-functions-plugin');
-  const launchDelete = useDeleteModal(
-    mainResource as K8sResourceKind,
-    undefined,
-    undefined,
-    t('Undeploy'),
-  );
+  return <Button variant="plain" aria-label={t('Delete')} icon={<TrashIcon />} isDisabled />;
+}
+
+function DeleteActionButton({ mainResource }: { mainResource: K8sResourceKind }) {
+  const { t } = useTranslation('plugin__console-functions-plugin');
+  const launchDelete = useDeleteModal(mainResource, undefined, undefined, t('Undeploy'));
 
   return (
     <Button
       variant="plain"
       aria-label={t('Delete')}
       icon={<TrashIcon />}
-      isDisabled={!mainResource}
       onClick={() => launchDelete()}
     />
   );

[matejvasek]

and mainResource ?? {} changes thruthines

[matejvasek]

and mainResource ?? {} changes thruthines

But maybe it's valid approach, I don't know.

[Cragsmann]

Suggested change

	const functions = useMemo(() => {
	const safeKnSvcs = knLoaded ? (knSvcs ?? []) : [];
	const safeDeps = depLoaded ? (deps ?? []) : [];
	return pairResources(safeKnSvcs, safeDeps);
	}, [knSvcs, knLoaded, deps, depLoaded]);
	const functions = useMemo(
	() => pairResources(
	knLoaded ? (knSvcs ?? []) : [],
	depLoaded ? (deps ?? []) : [],
	),
	[knSvcs, knLoaded, deps, depLoaded],
	);

[Cragsmann]

nit-picks