Skip to content

[release-ocm-2.12] ACM-32289: CVE-2026-42306 Bump assisted-service dep to pick up docker v28.5.2 - #1567

Open
shay23bra wants to merge 3 commits into
openshift:release-ocm-2.12from
shay23bra:as-bump-docker-release-ocm-2.12
Open

[release-ocm-2.12] ACM-32289: CVE-2026-42306 Bump assisted-service dep to pick up docker v28.5.2#1567
shay23bra wants to merge 3 commits into
openshift:release-ocm-2.12from
shay23bra:as-bump-docker-release-ocm-2.12

Conversation

@shay23bra

Copy link
Copy Markdown
Contributor

Bump assisted-service dependency to latest commit which includes docker/docker v28.5.2, fixing CVE-2026-42306.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@shay23bra: This pull request references ACM-32289 which is a valid jira issue.

Details

In response to this:

Bump assisted-service dependency to latest commit which includes docker/docker v28.5.2, fixing CVE-2026-42306.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a7a70b36-32ca-4fc2-8359-57fa936d5c81

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 26, 2026
@openshift-ci
openshift-ci Bot requested review from eliorerz and gamli75 July 26, 2026 12:34
@openshift-ci

openshift-ci Bot commented Jul 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shay23bra
Once this PR has been reviewed and has the lgtm label, please assign oourfali for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.65%. Comparing base (e50d1fa) to head (b5705b5).
⚠️ Report is 2 commits behind head on release-ocm-2.12.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.12    #1567      +/-   ##
====================================================
- Coverage             55.69%   55.65%   -0.05%     
====================================================
  Files                    87       87              
  Lines                  4106     4106              
====================================================
- Hits                   2287     2285       -2     
- Misses                 1651     1652       +1     
- Partials                168      169       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The Dockerfile already builds with GOFLAGS=-mod=mod. Align unit tests
to use the same mode, avoiding issues with vendored packages that
have subdirectories matching .gitignore patterns (e.g. build/).
@shay23bra

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

@shay23bra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp 5b72923 link true /test e2e-ai-operator-ztp
ci/prow/subsystem-test 5b72923 link true /test subsystem-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

The vendored docker/docker v28.5.2 includes an api/types/build sub-package
that conflicts with .gitignore build rule. Use -mod=mod for all Go build
and test commands to resolve dependencies from the module cache instead
of the incomplete vendor directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants