Skip to content

Allow hub side templating for image pre-caching. #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yprokule wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow hub side templating for image pre-caching. #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e/configuration/reference-crs/optional/other/precache/controlplane-olm-pinned-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
# Replace the pinnedImages list below with the actual images required for
# your target release(s). Use patches in the PolicyGenerator to override
# this list with environment-specific image digests.
pinnedImages: {}
pinnedImages: ""

@imiller0 imiller0 Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct form here would be an empty list, eg []. The object/dict definitely isn't correct...

# - name: "registry.redhat.io/redhat/redhat-operator-index@sha256:..."
# - name: "registry.redhat.io/odf4/odf-rhel9-operator@sha256:..."
# - name: "registry.redhat.io/openshift4/ose-sriov-network-rhel9-operator@sha256:..."
Expand Down
2 changes: 1 addition & 1 deletion ...figuration/reference-crs/optional/other/precache/controlplane-releases-pinned-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
# Replace the pinnedImages list below with the actual release images required
# for your target release(s). Use patches in the PolicyGenerator to override
# this list with environment-specific image digests.
pinnedImages: {}
pinnedImages: ""
# - name: "quay.io/openshift-release-dev/ocp-release@sha256:..."
# - name: "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:..."
# - name: "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:..."
Expand Down
2 changes: 1 addition & 1 deletion telco-core/configuration/reference-crs/optional/other/precache/worker-olm-pinned-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
# Replace the pinnedImages list below with the actual images required for
# your target release(s). Use patches in the PolicyGenerator to override
# this list with environment-specific image digests.
pinnedImages: {}
pinnedImages: ""
# - name: "registry.redhat.io/redhat/redhat-operator-index@sha256:..."
# - name: "registry.redhat.io/odf4/odf-rhel9-operator@sha256:..."
# - name: "registry.redhat.io/openshift4/ose-sriov-network-rhel9-operator@sha256:..."
Expand Down
2 changes: 1 addition & 1 deletion ...re/configuration/reference-crs/optional/other/precache/worker-releases-pinned-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
# Replace the pinnedImages list below with the actual release images required
# for your target release(s). Use patches in the PolicyGenerator to override
# this list with environment-specific image digests.
pinnedImages: {}
pinnedImages: ""
# - name: "quay.io/openshift-release-dev/ocp-release@sha256:..."
# - name: "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:..."
# - name: "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:..."
Expand Down
Loading