CNF-26666: Fix wrong compare logic for different configuration files

[bborbely-rh]

Summary

• Backport kube-compare boolean gate fixes to release-4.22
• Use hasKey for optional boolean fields so explicit false values are not treated as unset

Files

• telco-core/.../metallb/addr-pool.yaml (autoAssign, avoidBuggyIPs)
• telco-core/.../metallb/bfd-profile.yaml (echoMode)
• telco-core/.../metallb/bgp-peer.yaml (disableMP)
• telco-hub/.../acm/acmProvisioning.yaml (disableVirtualMediaTLS)

Test plan

• kubectl-cluster_compare with fixture CRs using false for the affected boolean fields reports CRs with diffs: 0

Made with Cursor

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bborbely-rh
Once this PR has been reviewed and has the lgtm label, please assign lack for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fb160289-c7e4-41b9-9bed-59e9c55391d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hi @bborbely-rh. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@bborbely-rh: This pull request references CNF-26666 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Backport kube-compare boolean gate fixes to release-4.22
• Use hasKey for optional boolean fields so explicit false values are not treated as unset

Files

• telco-core/.../metallb/addr-pool.yaml (autoAssign, avoidBuggyIPs)
• telco-core/.../metallb/bfd-profile.yaml (echoMode)
• telco-core/.../metallb/bgp-peer.yaml (disableMP)
• telco-hub/.../acm/acmProvisioning.yaml (disableVirtualMediaTLS)

Test plan

• kubectl-cluster_compare with fixture CRs using false for the affected boolean fields reports CRs with diffs: 0

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.