-
Notifications
You must be signed in to change notification settings - Fork 77
OCPBUGS-85777: Add root CA expiration monitoring for cert-manager #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sebrandon1
wants to merge
2
commits into
openshift-kni:main
Choose a base branch
from
sebrandon1:root-ca-monitoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...n/reference-crs-kube-compare/optional/cert-manager/certManagerRootCAExpirationPolicy.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| apiVersion: policy.open-cluster-management.io/v1 | ||
| kind: Policy | ||
| metadata: | ||
| name: root-ca-expiration-monitor | ||
| namespace: default | ||
| annotations: | ||
| policy.open-cluster-management.io/categories: SC System and Communications Protection | ||
| policy.open-cluster-management.io/controls: SC-8 Transmission Confidentiality and Integrity | ||
| policy.open-cluster-management.io/standards: NIST 800-53 | ||
| spec: | ||
| disabled: false | ||
| remediationAction: enforce |
18 changes: 18 additions & 0 deletions
18
...ce-crs-kube-compare/optional/cert-manager/certManagerRootCAExpirationPolicyPlacement.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| apiVersion: cluster.open-cluster-management.io/v1beta1 | ||
| kind: Placement | ||
| metadata: | ||
| name: root-ca-expiration-placement | ||
| namespace: default | ||
| annotations: | ||
| argocd.argoproj.io/sync-wave: "-11" | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
| spec: | ||
| predicates: | ||
| - requiredClusterSelector: | ||
| labelSelector: | ||
| matchExpressions: | ||
| - key: local-cluster | ||
| operator: In | ||
| values: | ||
| - "true" |
17 changes: 17 additions & 0 deletions
17
...kube-compare/optional/cert-manager/certManagerRootCAExpirationPolicyPlacementBinding.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| apiVersion: policy.open-cluster-management.io/v1 | ||
| kind: PlacementBinding | ||
| metadata: | ||
| name: root-ca-expiration-placementbinding | ||
| namespace: default | ||
| annotations: | ||
| argocd.argoproj.io/sync-wave: "-11" | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
| placementRef: | ||
| name: root-ca-expiration-placement | ||
| apiGroup: cluster.open-cluster-management.io | ||
| kind: Placement | ||
| subjects: | ||
| - name: root-ca-expiration-monitor | ||
| apiGroup: policy.open-cluster-management.io | ||
| kind: Policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
.../configuration/reference-crs/optional/cert-manager/certManagerRootCAExpirationPolicy.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| # ACM Policy to create a PrometheusRule that alerts on root CA | ||
| # certificate expiration. Monitors the cert-manager certificate | ||
| # expiration metric and fires warnings at 90 days and critical | ||
| # alerts at 30 days before expiry. | ||
| apiVersion: policy.open-cluster-management.io/v1 | ||
| kind: Policy | ||
| metadata: | ||
| name: root-ca-expiration-monitor | ||
| namespace: default | ||
| annotations: | ||
| policy.open-cluster-management.io/categories: SC System and Communications Protection | ||
| policy.open-cluster-management.io/controls: SC-8 Transmission Confidentiality and Integrity | ||
| policy.open-cluster-management.io/standards: NIST 800-53 | ||
| argocd.argoproj.io/sync-wave: "-10" | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
| spec: | ||
| disabled: false | ||
| policy-templates: | ||
| - objectDefinition: | ||
| apiVersion: policy.open-cluster-management.io/v1 | ||
| kind: ConfigurationPolicy | ||
| metadata: | ||
| name: root-ca-expiration-prometheusrule | ||
| spec: | ||
| remediationAction: enforce | ||
| severity: high | ||
| object-templates: | ||
| - complianceType: musthave | ||
| objectDefinition: | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: PrometheusRule | ||
| metadata: | ||
| name: cert-manager-root-ca-expiration | ||
| namespace: cert-manager-operator | ||
| spec: | ||
| groups: | ||
| - name: cert-manager-root-ca | ||
| rules: | ||
| - alert: CertManagerRootCAExpiringSoon | ||
| annotations: | ||
| summary: 'Root CA certificate {{`{{ $labels.name }}`}} is expiring soon' | ||
| description: 'The root CA certificate {{`{{ $labels.name }}`}} in namespace {{`{{ $labels.namespace }}`}} expires in less than 90 days.' | ||
| # Update name="root-ca" if your cert-manager Certificate resource uses a different name | ||
| expr: | | ||
| certmanager_certificate_expiration_timestamp_seconds{name="root-ca",namespace="cert-manager"} - time() < 90 * 24 * 3600 | ||
| for: 1h | ||
| labels: | ||
| severity: warning | ||
| - alert: CertManagerRootCAExpirationCritical | ||
| annotations: | ||
| summary: 'Root CA certificate {{`{{ $labels.name }}`}} is about to expire' | ||
| description: 'The root CA certificate {{`{{ $labels.name }}`}} in namespace {{`{{ $labels.namespace }}`}} expires in less than 30 days. Immediate action required.' | ||
| expr: | | ||
| certmanager_certificate_expiration_timestamp_seconds{name="root-ca",namespace="cert-manager"} - time() < 30 * 24 * 3600 | ||
| for: 1h | ||
| labels: | ||
| severity: critical | ||
| remediationAction: enforce | ||
18 changes: 18 additions & 0 deletions
18
...ation/reference-crs/optional/cert-manager/certManagerRootCAExpirationPolicyPlacement.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| apiVersion: cluster.open-cluster-management.io/v1beta1 | ||
| kind: Placement | ||
| metadata: | ||
| name: root-ca-expiration-placement | ||
| namespace: default | ||
| annotations: | ||
| argocd.argoproj.io/sync-wave: "-11" | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
| spec: | ||
| predicates: | ||
| - requiredClusterSelector: | ||
| labelSelector: | ||
| matchExpressions: | ||
| - key: local-cluster | ||
| operator: In | ||
| values: | ||
| - "true" |
17 changes: 17 additions & 0 deletions
17
...eference-crs/optional/cert-manager/certManagerRootCAExpirationPolicyPlacementBinding.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| apiVersion: policy.open-cluster-management.io/v1 | ||
| kind: PlacementBinding | ||
| metadata: | ||
| name: root-ca-expiration-placementbinding | ||
| namespace: default | ||
| annotations: | ||
| argocd.argoproj.io/sync-wave: "-11" | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
| placementRef: | ||
| name: root-ca-expiration-placement | ||
| apiGroup: cluster.open-cluster-management.io | ||
| kind: Placement | ||
| subjects: | ||
| - name: root-ca-expiration-monitor | ||
| apiGroup: policy.open-cluster-management.io | ||
| kind: Policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.