Skip to content

Revert "Restore cert-manager to RAN profile" - #881

Open
sebrandon1 wants to merge 1 commit into
openshift-kni:mainfrom
sebrandon1:revert-ran-cert-manager
Open

Revert "Restore cert-manager to RAN profile"#881
sebrandon1 wants to merge 1 commit into
openshift-kni:mainfrom
sebrandon1:revert-ran-cert-manager

Conversation

@sebrandon1

Copy link
Copy Markdown
Contributor

Summary

Reverts PR #805.

cert-manager is not ready for 4.22.z (targeted for November). Remove it from the RAN profile until then.

Related:

@openshift-ci
openshift-ci Bot requested review from cgoncalves and fedepaol July 30, 2026 16:13
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign irinamihai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 672d7e5b-1514-462f-a013-8ce85d213140

📥 Commits

Reviewing files that changed from the base of the PR and between 45be675 and 9ca4cb4.

📒 Files selected for processing (2)
  • telco-ran/configuration/kube-compare-reference/hack/compare_ignore
  • telco-ran/configuration/kube-compare-reference/metadata.yaml
💤 Files with no reviewable changes (2)
  • telco-ran/configuration/kube-compare-reference/metadata.yaml
  • telco-ran/configuration/kube-compare-reference/hack/compare_ignore

📝 Walkthrough

Walkthrough

Cert-manager policy, operator, certificate, issuer, ingress, and API configuration manifests are removed. Comparison references are updated for nmstate configuration and a Node lookup substitution.

Changes

Cert-manager cleanup and comparison updates

Layer / File(s) Summary
Remove cert-manager references
telco-ran/configuration/acmpolicygenerator/ran-common.yaml, telco-ran/configuration/kube-compare-reference/hack/compare_ignore
Removes cert-manager manifest placeholders and comparison ignore entries.
Update comparison configuration
telco-ran/configuration/kube-compare-reference/hack/default_value.yaml, telco-ran/configuration/kube-compare-reference/metadata.yaml
Adds a Node lookup substitution and replaces the optional cert-manager component with optional nmstate configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: cgoncalves, fedepaol

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies that the pull request reverts the cert-manager restoration and matches the main changeset.
Description check ✅ Passed The description directly explains that cert-manager is removed from the RAN profile because it is not ready for 4.22.z.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

cert-manager is not ready for 4.22.z and will not be until November.
Remove it from the RAN profile until then.

This reverts commit f61201a.
@sebrandon1
sebrandon1 force-pushed the revert-ran-cert-manager branch from 45be675 to 9ca4cb4 Compare August 11, 2026 13:06
@sebrandon1

Copy link
Copy Markdown
Contributor Author

Rebased against upstream/main. Resolved merge conflict in telco-ran/configuration/kube-compare-reference/hack/compare_ignore: upstream added cert-manager config CR entries to the ignore list; since this PR reverts cert-manager from the RAN profile, those entries were removed in favor of the ClusterLogging 5->6 cleanup entry. Kustomize validation passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant