Skip to content

Enable timer_migration=1 for all use cases until OCPBUGS-86541 fix - #859

Open
MarSik wants to merge 1 commit into
openshift-kni:release-4.21from
MarSik:release-4.21-timer-migration
Open

Enable timer_migration=1 for all use cases until OCPBUGS-86541 fix#859
MarSik wants to merge 1 commit into
openshift-kni:release-4.21from
MarSik:release-4.21-timer-migration

Conversation

@MarSik

@MarSik MarSik commented Jul 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@openshift-ci
openshift-ci Bot requested review from fedepaol and yanirq July 14, 2026 08:31
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: ada9b2cf-c1fc-4cc9-b15d-3e68f24c22c1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@MarSik

MarSik commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@imiller0 Should be merge it?

@imiller0

imiller0 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@MarSik Yes, but please add a comment in the code which identifies this specifically as a workaround pending fix for OCPBUGS-86541. That way we have a reminder that it needs to be removed.

@MarSik
MarSik force-pushed the release-4.21-timer-migration branch 2 times, most recently from ee16f87 to 94f9fc6 Compare August 21, 2026 14:56
@yanirq

yanirq commented Aug 23, 2026

Copy link
Copy Markdown
Member

@MarSik please make sure the lint check pass

…kported

Signed-off-by: Martin Sivak <msivak@redhat.com>
@MarSik
MarSik force-pushed the release-4.21-timer-migration branch from 94f9fc6 to 1e9f267 Compare August 24, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants