CNF-23574: Bump ZTP images from RHEL8 to RHEL9 #743
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,8 +102,8 @@ mirror: | |
| channels: | ||
| - name: stable-v1 | ||
| additionalImages: | ||
| - name: registry.redhat.io/ubi9/ubi:latest | ||
| - name: registry.redhat.io/openshift5/ztp-site-generate-rhel9:v5.0 | ||
| - name: registry.redhat.io/rhel9/support-tools:latest | ||
|
Comment on lines
+105
to
+107
There was a problem hiding this comment. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
for image in \
registry.redhat.io/ubi8/ubi:latest \
registry.redhat.io/rhel8/support-tools:latest; do
grep -Fq -- "name: ${image}" \
telco-hub/install/mirror-registry/imageset-config.yaml || {
echo "Missing additionalImages entry: ${image}" >&2
exit 1
}
doneRepository: openshift-kni/telco-reference Length of output: 234 🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- repository conventions ---'
find /tmp/coderabbit-repo-knowledge/openshift-kni-telco-reference-8264d54d -type f -name '*.md' -maxdepth 3 -print \
-exec sh -c 'echo "--- $1"; head -80 "$1"' _ {} \;
printf '%s\n' '--- ImageSetConfiguration ---'
sed -n '1,140p' telco-hub/install/mirror-registry/imageset-config.yaml
printf '%s\n' '--- referenced mirror mappings ---'
sed -n '1,40p' telco-hub/configuration/example-overlays-config/registry/itms-generic-mirrors-patch.yaml
sed -n '1,45p' telco-hub/configuration/reference-crs/required/registry/itms-generic.yaml
sed -n '65,105p' telco-hub/configuration/reference-crs/required/acm/acmMirrorRegistryCM.yamlRepository: openshift-kni/telco-reference Length of output: 6768 🌐 Web query:
💡 Result: In the OpenShift oc-mirror v2 plugin, the mirror.additionalImages section of the ImageSetConfiguration is used to define specific container images for the mirroring process [1][2]. Regarding the behavior of image references and omitted tags: 1. Image Reference Requirements: You must provide an explicit registry hostname for every image listed under additionalImages [1][3][4]. Failing to include the explicit registry hostname can cause the plugin to mirror images to incorrect or unexpected target paths [1][4][5]. 2. Tag Behavior: - When a tag is specified in the name field (e.g., registry.redhat.io/ubi8/ubi:latest), that specific tag is used for the mirror operation [1][4][5]. - If no tag is provided in the name field, oc-mirror calculates and applies a tag based on the image’s partial digest [4][5]. - You can explicitly control the destination tag by using the optional targetTag field [4][5]. If targetTag is configured, it overrides the tag derived from the name field [4][5]. In summary, the plugin is designed to process the specific image reference provided. If you omit a tag in the name field, the plugin does not mirror all tags for that repository; instead, it automatically derives a tag from the image's digest to ensure a deterministic reference is mirrored [4][5]. Citations:
Keep retained legacy images in the mirror input, or remove their mirror mappings.
🤖 Prompt for AI AgentsSource: MCP tools |
||
| - name: registry.redhat.io/rhacm2/multicluster-operators-subscription-rhel9:v2.17.0-1 | ||
| helm: {} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need ubi/rhel8 with this done? this was the last 8 container right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm maybe @imiller0 ? (I think yes)