Skip to content

Update hotROD example - #7094

Open
martialblog wants to merge 1 commit into
opensearch-project:mainfrom
martialblog:update-hotrod
Open

Update hotROD example#7094
martialblog wants to merge 1 commit into
opensearch-project:mainfrom
martialblog:update-hotrod

Conversation

@martialblog

Copy link
Copy Markdown

Description

This PR updates the hotROD example

  • Update OpenSearch to 3.8.0
  • Update opentelemetry-collector to 0.158.0
  • Remove jaeger-agent
  • Replace deprecated otel_trace_source with otlp_traces

Issues Resolved

Resolves #4923

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

- Update OpenSearch to 3.8.0
- Update opentelemetry-collector to 0.158.0
- Remove jaeger-agent
- Replace deprecated otel_trace_source with otlp_traces

Signed-off-by: Markus Opolka <markus.opolka@netways.de>
@github-actions

Copy link
Copy Markdown

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit fcc62e6.

Hard block: Issues at High severity or above will block this PR from merging.

PathLineSeverityDescription
examples/jaeger-hotrod/docker-compose.yml4highContainer image changed from 'opensearchproject/data-prepper:2' to 'docker.io/opensearchproject/data-prepper:2.16.0'. Maintainers must verify the pinned artifact at docker.io matches the expected image.
examples/jaeger-hotrod/docker-compose.yml13highContainer image changed from 'otel/opentelemetry-collector:0.64.1' to 'docker.io/otel/opentelemetry-collector-contrib:0.158.0'. Additionally, this switches from the base collector to the 'contrib' distribution, which bundles a significantly larger set of third-party components. Maintainers must verify both the registry source and the expanded attack surface of the contrib image.
examples/jaeger-hotrod/docker-compose.yml37highContainer image changed from 'jaegertracing/example-hotrod:1.41.0' to 'docker.io/jaegertracing/example-hotrod:2.20.0'. Maintainers must verify the pinned artifact at docker.io matches the expected image.
examples/jaeger-hotrod/docker-compose.yml48highContainer image changed from 'opensearchproject/opensearch:2.16.0' to 'docker.io/opensearchproject/opensearch:3.8.0' (major version bump from 2.x to 3.x). Maintainers must verify the pinned artifact at docker.io matches the expected image.
examples/jaeger-hotrod/docker-compose.yml63highContainer image changed from 'opensearchproject/opensearch-dashboards:2.16.0' to 'docker.io/opensearchproject/opensearch-dashboards:3.8.0' (major version bump from 2.x to 3.x). Maintainers must verify the pinned artifact at docker.io matches the expected image.

The table above displays the top 10 most important findings.

Total: 5 | Critical: 0 | High: 5 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@martialblog

Copy link
Copy Markdown
Author

Note on the images. having a full qualified Container Image name with an explicit registry, like docker.io/opensearchproject/data-prepper, is preferable for container runtimes that aren't Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removes Jaeger Agent from Jaeger Hotrod Demo

1 participant