fix(msggateway): avoid closed channel panic in super group push - #3767
Open
buvidk1234 wants to merge 1 commit into
Open
fix(msggateway): avoid closed channel panic in super group push#3767buvidk1234 wants to merge 1 commit into
buvidk1234 wants to merge 1 commit into
Conversation
buvidk1234
requested review from
FGadvancer,
skiffer-git and
withchao
as code owners
July 8, 2026 16:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🅰 Please add the issue ID after "Fixes #"
Fixes #
Summary
Fix a panic risk in
SuperGroupOnlineBatchPushOneMsgwhen queue enqueue fails.Problem
SuperGroupOnlineBatchPushOneMsguses a result channel to collect per-user push results and closes the channel when all pending users are handled.In the
PushCtxerror branch, the previous code decremented the pending counter and could close the result channel before sending the fallback result. If the failed enqueue was the last pending item, the following send would panic:This can happen on abnormal paths such as request context cancellation while the in-memory queue is unable to accept another task, or when the queue has already stopped.
Changes
pushResult.PushCtxerror paths send the user result before decrementing the pending counter.