Conversation
bmtcril
commented
Apr 21, 2026
| from unittest import TestCase | ||
| from unittest.mock import ANY, Mock, call, patch | ||
|
|
||
| import attr |
bmtcril
commented
Apr 21, 2026
| pass | ||
|
|
||
|
|
||
| # Copied from openedx_events.event_bus.avro.tests.test_utilities |
Author
There was a problem hiding this comment.
These used to be imported, but at some point openedx-events stopped bundling the tests
bmtcril
commented
Apr 21, 2026
| topic_record_subject_name_strategy # pylint: disable=protected-access,comparison-with-callable | ||
| assert value_ser._subject_name_func ==\ | ||
| topic_record_subject_name_strategy # pylint: disable=protected-access,comparison-with-callable | ||
| # pylint: disable=protected-access,comparison-with-callable |
Author
There was a problem hiding this comment.
This was the actual change in the rest of this file, pylint complained about line length and ruff made a million other irrelevant changes.
bmtcril
commented
Apr 21, 2026
|
|
||
| upgrade: export CUSTOM_COMPILE_COMMAND=make upgrade | ||
| upgrade: ## update the requirements/*.txt files with the latest packages satisfying requirements/*.in | ||
| pip install -qr requirements/pip.txt |
Author
There was a problem hiding this comment.
Needed to fix the actual errors blocking make upgrade so I could run that.
15 tasks
bmtcril
force-pushed
the
bmtcril/test_type_hinted_openedxevents
branch
from
July 15, 2026 13:46
385ffdd to
c55ac2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements upgrades haven't been working in months, so this also has fixes for that just to get things running again, but the real change is just using the new openedx-events.
Merge checklist:
Check off if complete or not applicable: