Repository navigation
fix: keep the ORA editor tabs clear of Studio's fullscreen button - #2443
ihor-romaniuk wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2443 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 198 198
Lines 22842 22842
Branches 1551 1551
=======================================
Hits 21807 21807
Misses 780 780
Partials 255 255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Studio's XBlock editor modal now floats a fullscreen button over its top-right corner. The ORA editor hides Studio's modal header and puts its own tabs in that strip, so the button covered the last tab and swallowed clicks on it. * fix: reserve room for the fullscreen button in the editor tab bar * chore: bump version
a96b6e4 to
d5a28ca
Compare
|
Hi @ihor-romaniuk, thank you for this contribution! Since it's touching user-facing code, it will need product approval before it can be merged. Please follow the instructions for the Clear-Scope Bug Fixes contribution type to get the product review process started. |
|
@openedx/openedx-product-managers - requesting product review, following the Clear-Scope Bug Fixes process. Bug report: #2450 In Studio's ORA editor, the fullscreen button sits on top of the Settings tab and swallows clicks meant for it, so the tab can't be opened the normal way. The fix reserves the width of the button on the right edge of the tab bar - CSS only, no change to behaviour or copy. Before/after screenshots are in the description above. cc @itsjeyd |
|
Hi @openedx/openedx-product-managers, could you please give this a look? |
|
Thanks for the fix @ihor-romaniuk. The fix is necessary, thank you for contributing! One note: currently in narrow viewports, the tab options overlap and Prompt will be pushed off screen. What's the relative lift to change the heading sizing from a fixed px to a flex so that in narrow viewports, the tabs can flex below the header text? Screenshot below
|

TL;DR - Studio's XBlock editor floats a fullscreen button over the top-right corner of the modal. The ORA editor hides Studio's modal header and puts its own tab bar in that strip, so the button lands on top of the last tab — Settings — and swallows clicks meant for it. The tab bar now leaves room for the button.
Fixes #2450
What changed?
Implementation notes
display: noneon Studio's.modal-headerand reuses that strip for its tabs; every other XBlock editor keeps the header, and the button sits inside it with nothing underneath.right: 30pxplus the button'swidth: 44px, fromcms/static/sass/elements/_modal-window.scss.padding-right, not the bi-apppadding-right()mixin: Studio positions the button with an unflippedright, and its-rtlbundle keeps it on the right, so the padding has to stay on the right too.Screenshot
Developer Checklist
make staticwas neededTesting Instructions
Verified locally
document.elementFromPointat the centre of Settings returns the tab anchor. Before the fix it returned the fullscreen buttonx1246–1290, Settings tabx1200–1304 before; the tab ends at 1230 aftermake staticnpm run lintReviewer Checklist
Collectively, these should be completed by reviewers of this PR: