Skip to content

fix: keep the ORA editor tabs clear of Studio's fullscreen button - #2443

Open
ihor-romaniuk wants to merge 1 commit into
openedx:masterfrom
raccoongang:fix/ora-editor-tabs-fullscreen-overlap
Open

ihor-romaniuk wants to merge 1 commit into
openedx:masterfrom
raccoongang:fix/ora-editor-tabs-fullscreen-overlap

Conversation

@ihor-romaniuk

@ihor-romaniuk ihor-romaniuk commented Aug 28, 2026 •

Copy link
Copy Markdown

TL;DR - Studio's XBlock editor floats a fullscreen button over the top-right corner of the modal. The ORA editor hides Studio's modal header and puts its own tab bar in that strip, so the button lands on top of the last tab — Settings — and swallows clicks meant for it. The tab bar now leaves room for the button.

Fixes #2450

What changed?

  • The ORA editor tab bar reserves 74px on its right edge, so the last tab ends before the fullscreen button starts.
  • Recompiled the static assets and bumped the version.
Implementation notes
  • Only this editor is affected. ORA sets an inline display: none on Studio's .modal-header and reuses that strip for its tabs; every other XBlock editor keeps the header, and the button sits inside it with nothing underneath.
  • 74px is Studio's own geometry: right: 30px plus the button's width: 44px, from cms/static/sass/elements/_modal-window.scss.
  • Plain padding-right, not the bi-app padding-right() mixin: Studio positions the button with an unflipped right, and its -rtl bundle keeps it on the right, so the padding has to stay on the right too.

Screenshot

Before After
r-01-ora-tabs-before r-02-ora-tabs-after

Developer Checklist

Testing Instructions

  1. In Studio, open a unit that contains an Open Response Assessment component and click Edit.
  2. Expected: all five tabs — Prompt, Rubric, Schedule, Assessment Steps, Settings — are fully visible, with the fullscreen button to the right of them. Before this change the button sat on top of Settings.
  3. Click Settings.
  4. Expected: the Settings tab opens. Before this change the click hit the fullscreen button instead and the modal went fullscreen.
  5. Click the fullscreen button, then click through all five tabs.
  6. Expected: the modal expands and every tab still works.
  7. Open the editor of any other XBlock (for example a Problem or a Video).
  8. Expected: unchanged.

Verified locally

Check Result
ORA editor in a running Studio tabs clear the button; document.elementFromPoint at the centre of Settings returns the tab anchor. Before the fix it returned the fullscreen button
Measured geometry button x 1246–1290, Settings tab x 1200–1304 before; the tab ends at 1230 after
make static builds clean; the rule lands in the LTR, RTL and LMS bundles
npm run lint clean
Not verified an RTL locale was checked in the compiled CSS only, not in a browser. In RTL the tabs pack to the left and the button stays on the right, so they do not meet

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @openedx/openedx-unmaintained.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 28, 2026
@ihor-romaniuk ihor-romaniuk self-assigned this Aug 28, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.46%. Comparing base (b60672e) to head (d5a28ca).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2443   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         198      198           
  Lines       22842    22842           
  Branches     1551     1551           
=======================================
  Hits        21807    21807           
  Misses        780      780           
  Partials      255      255           
Flag Coverage Δ
unittests 95.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AhtishamShahid
AhtishamShahid removed their request for review September 1, 2026 08:06
Studio's XBlock editor modal now floats a fullscreen button over its
top-right corner. The ORA editor hides Studio's modal header and puts
its own tabs in that strip, so the button covered the last tab and
swallowed clicks on it.

* fix: reserve room for the fullscreen button in the editor tab bar
* chore: bump version
@ihor-romaniuk
ihor-romaniuk force-pushed the fix/ora-editor-tabs-fullscreen-overlap branch from a96b6e4 to d5a28ca Compare September 11, 2026 07:50
@itsjeyd

itsjeyd commented Sep 15, 2026

Copy link
Copy Markdown

Hi @ihor-romaniuk, thank you for this contribution! Since it's touching user-facing code, it will need product approval before it can be merged.

Please follow the instructions for the Clear-Scope Bug Fixes contribution type to get the product review process started.

@itsjeyd itsjeyd added the product review PR requires product review before merging label Sep 15, 2026
@itsjeyd itsjeyd moved this from Needs Triage to Product Review in Contributions Sep 15, 2026
@itsjeyd itsjeyd moved this from Product Review to Waiting on Author in Contributions Sep 15, 2026
@ihor-romaniuk

Copy link
Copy Markdown
Author

@openedx/openedx-product-managers - requesting product review, following the Clear-Scope Bug Fixes process.

Bug report: #2450

In Studio's ORA editor, the fullscreen button sits on top of the Settings tab and swallows clicks meant for it, so the tab can't be opened the normal way. The fix reserves the width of the button on the right edge of the tab bar - CSS only, no change to behaviour or copy. Before/after screenshots are in the description above.

cc @itsjeyd

@itsjeyd itsjeyd moved this from Waiting on Author to Product Review in Contributions Sep 22, 2026
@itsjeyd

itsjeyd commented Sep 29, 2026

Copy link
Copy Markdown

Hi @openedx/openedx-product-managers, could you please give this a look?

@edschema

Copy link
Copy Markdown

Thanks for the fix @ihor-romaniuk. The fix is necessary, thank you for contributing! One note: currently in narrow viewports, the tab options overlap and Prompt will be pushed off screen. What's the relative lift to change the heading sizing from a fixed px to a flex so that in narrow viewports, the tabs can flex below the header text? Screenshot below

image

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.

Projects

Status: Product Review

Development

Successfully merging this pull request may close these issues.

Studio's fullscreen button covers the ORA editor's Settings tab and swallows its clicks

4 participants