Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,12 @@
html_favicon = "https://logos.openedx.org/open-edx-favicon.ico"
release = "Latest"

# Sphinx defaults to hyperlinking scaled images (any `.. image::` with a
# `:height:`, `:width:`, or `:scale:` option) to their own unscaled file.
# Our role-guide tiles use `:height:` purely for layout, so this made
# clicking a tile image open the raw image instead of the linked page.
html_scaled_image_link = False

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the clicking the tile linking to a raw image issue, but doesn't actually fix the problem of the homepage images linking to the page (now clicking the image just does nothing; see https://docsopenedxorg--1513.org.readthedocs.build/en/1513/)

I also don't actually think we want this, though. There are plenty of images within docs pages that have text that's a bit hard to see when you are looking at the docs page, and being able to click on the image to enlarge it is really helpful.

Do you think there's a way to fix, very specifically, the images on the homepage linking to the pages - so here,

Image

clicking on the image would link to the "Educator's Home", without destroying the ability to enlarge other site images?


html_static_path = ["_static"]

html_css_files = [
Expand Down