Repository navigation
ci: bump golangci-lint to v2.15 - #5585
Merged
Merged
Conversation
Fix new errcheck warnings about unchecked errors received from channels: libcontainer/configs/config.go:632:3: Error return value is not checked (errcheck) libcontainer/logs/logs_linux_test.go:62:7: Error return value is not checked (errcheck) notify_socket_test.go:73:7: Error return value is not checked (errcheck) In the hook timeout case, the error from Wait is expected after Kill, so add a nolint annotation (using "_ =" upsets staticcheck's S1005). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
Oct 27, 2026
AkihiroSuda
enabled auto-merge
October 27, 2026 22:02
Merged
via the queue into
opencontainers:main
with commit Oct 27, 2026
f4ec3e2
96 of 97 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix new errcheck warnings about unchecked errors received from channels:
In the hook timeout case, the error from Wait is expected after Kill,
so add a nolint annotation (using "_ =" upsets staticcheck's S1005).