Repository navigation
Conversation
Fixes opencontainers#5550 Assisted-by: Codex GPT-6 Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
Contributor
|
Check is complicated, and is done in |
Contributor
|
closing in favor of #5564 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5550
OCI Runtime Specification requires a runtime to fail when an errno return value is provided for an action that does not support it.
runccurrently discardsdefaultErrnoRetand per-syscallerrnoRetforSCMP_ACT_ALLOW, so invalid seccomp configurations are accepted.Reject unsupported action/errno combinations while preserving
SCMP_ACT_ERRNOandSCMP_ACT_TRACE. Include coverage for default and per-syscall actions.Tests:
go test -tags seccomp ./libcontainer/seccomp ./libcontainer/specconv