feat(native-eval): export tool discovery telemetry - #60
Conversation
|
Codex review: needs changes before merge. Reviewed August 4, 2026, 8:21 PM ET / August 5, 2026, 00:21 UTC. ClawSweeper reviewWhat this changesThe PR adds normalized native-harness discovery telemetry, including a new CSV export and trace-fidelity metadata, to the research audit. Merge readinessKeep open: current main does not export this telemetry, and the PR has a focused, source-backed implementation. One previously reported P3 documentation gap remains before merge. Priority: P3 Review scores
Verification
How this fits togetherShellBench’s native-evaluation audit consumes a run index and extracted harness traces, then produces campaign tables used to assess reproducibility and comparability. This change adds separate discovery-operation evidence alongside existing task, turn, tool, and model-identity outputs. flowchart LR
A[Run index] --> C[Research audit exporter]
B[Extracted native traces] --> C
C --> D[Discovery telemetry normalization]
C --> E[Existing audit tables]
D --> F[Discovery events CSV]
E --> G[Campaign audit]
F --> G
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Keep the separate telemetry export and document its retention location plus discovery-state, count-semantics, and trace-fidelity meanings in the campaign contract. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds a research-audit capability rather than repairing an established failing runtime path; its stated after-fix artifact export is the relevant validation. Is this the best way to solve the issue? No: the exporter is a suitable implementation, but the campaign runbook must define the new retained artifact and how to interpret its fields. Full review comments:
Overall correctness: patch is correct AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (31 earlier review cycles; latest 8 shown)
|
What does this PR do?
Exports native-harness tool discovery operations separately from final tool
calls and records the trace fidelity needed to interpret missing events.
Why?
Fixes #59.
The existing research audit records
tool_search_codeas one wrapper call butdrops OpenClaw's embedded catalog and search/describe/call counters. It also
cannot distinguish disabled discovery from unsupported or unobservable native
events, which makes cross-harness comparisons produce fake zeros.
Changes
discovery_events.csvwith normalized search, describe, and call countsTests
python -m pytest -q tests/test_native_eval_research_audit.pypython -m ruff check scripts/native_eval/research_audit.py tests/test_native_eval_research_audit.pyall three tasks report the expected runner SHA, session fidelity,
disableddiscovery state, and zero discovery operations