fix: apply native reasoning effort to harnesses - #54
Conversation
|
Codex review: needs maintainer review before merge. Reviewed August 4, 2026, 8:18 PM ET / August 5, 2026, 00:18 UTC. ClawSweeper reviewWhat this changesThis PR carries planned reasoning effort into native OpenClaw, Hermes, Codex, and Claude Code commands while preserving each harness’s default when no effort is planned. Merge readinessKeep open: the patch is functionally sound on the reviewed source; fleet dispatch reads reasoning effort from the run-index entry itself, so omitting it from Likely related people: vincentkoc — recent native-eval contributor (high confidence). Priority: P1 Review scores
Verification
How this fits togetherShellBench evaluation plans assign a model, harness, and reasoning level to each run-index entry. Fleet dispatch forwards those settings to a remote job, which builds the native harness command and writes run artifacts and metadata. flowchart LR
Plan[Evaluation plan] --> Index[Run index]
Index --> Fleet[Fleet dispatcher]
Fleet --> Settings[Remote run settings]
Settings --> Job[Native run job]
Job --> Harnesses[Native harness clients]
Harnesses --> Results[Artifacts and manifest]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land the narrow propagation after a redacted smoke dispatch confirms each pinned native client accepts its mapped effort setting and Claude Code receives Do we have a high-confidence way to reproduce the issue? Yes—source inspection provides a high-confidence path: create a planned run with an effort level, dispatch it, and inspect the generated native command/config for all four harnesses. Is this the best way to solve the issue? Yes—the proposed single RunSpec value plus native-client mappings is the narrowest maintainable repair and preserves unspecified defaults. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (31 earlier review cycles; latest 8 shown)
|
What does this PR do?
Propagates the native eval plan's reasoning effort into OpenClaw, Hermes,
Codex, and Claude Code client controls.
Why?
Fixes #53. Without this, a run can be labeled
highwhile OpenClaw executeswith thinking disabled, invalidating cross-harness quality and efficiency
comparisons.
Changes
reasoning_effortinRunSpecand the run manifestxhighto Claude Code'smaxlow,medium,high, andxhighacross all four harnessesTests