fix: accept Claude native trajectories - #52
Conversation
|
Codex review: needs maintainer review before merge. Reviewed August 3, 2026, 4:13 PM ET / 20:13 UTC. ClawSweeper reviewWhat this changesThe PR classifies the pinned Claude Code native harness as emitting real trajectory events and adds coverage requiring all pinned native harnesses to use that mode. Merge readinessKeep this member-authored PR open for maintainer sign-off. The patch is a narrow, source-supported correction: Claude Code already emits validated real trajectories, but its harness name is omitted from the manifest allowlist that aggregation requires for eligibility. Priority: P2 Review scores
Verification
How this fits togetherShellBench’s native runner converts each harness’s execution records into a trajectory and writes the harness classification into the run manifest. Aggregation reads that classification with per-task trajectory status to decide whether a completed run is eligible for native benchmark reporting. flowchart LR
A[Claude Code stream-json events] --> B[Claude trajectory converter]
B --> C[Trajectory metadata]
C --> D[Native run manifest]
D --> E[Aggregation eligibility check]
E --> F[Benchmark summary]
Decision needed
Why: The source and live-run summary support the correction, but the classification changes what future benchmark data is eligible for longitudinal aggregation and publication. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Approve the existing narrow allowlist correction if maintainers accept the validated Claude Code stream-json converter as real native evidence, then retain the all-harness regression test to prevent future manifest/adapter drift. Do we have a high-confidence way to reproduce the issue? Yes, at source level: current main converts completed Claude Code stream-json records into real trajectories, while the manifest allowlist still returns unsupported for claude-code; the PR body also reports a four-task after-fix native run classified as real. Is this the best way to solve the issue? Yes, conditionally: changing the single manifest allowlist entry is the narrowest repair and the added all-harness assertion prevents recurrence, provided maintainers approve the benchmark evidence-classification policy. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (22 earlier review cycles; latest 8 shown)
|
What does this PR do?
Marks Claude Code native trajectories as real harness events so completed Claude runs remain eligible for native aggregation.
Why?
The native runner already converts Claude Code
stream-jsonoutput intotrajectory.json, but the harness allowlist omittedclaude-code. Aggregation therefore classified otherwise valid Claude runs astrajectory_unavailable.Changes
claude-codeto the real-trajectory harness allowlistreal_harness_eventsLive proof
A native Claude Code control run completed four tasks with four result files, four valid completed results, and no infrastructure failures. Aggregation classified every trajectory as
real; the run remained ineligible only because it was intentionally marked as an exploratory four-task subset.4/40.753truerealfor all four tasks0exploratory_subsetTests
python -m pytest -qpasses locally (444 passed, 5 skipped)python -m ruff check clawbench app.py scripts testspasses locally