Skip to content

fix(web): normalize PDF attachment filenames safely #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vincentkoc wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(web): normalize PDF attachment filenames safely #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ ENV CLICKCLACK_WEB_VERSION=$CLICKCLACK_WEB_VERSION
WORKDIR /src
RUN npm install -g pnpm@11.20.0
COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./
COPY patches patches
COPY apps/web/package.json apps/web/package.json
COPY packages/protocol/package.json packages/protocol/package.json
COPY packages/sdk-ts/package.json packages/sdk-ts/package.json
Expand Down
4 changes: 2 additions & 2 deletions apps/api/internal/webassets/dist/200.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
<link href="/_app/immutable/chunks/uCPLfb5l.js" rel="modulepreload">
<link href="/_app/immutable/chunks/DK3Fl9T5.js" rel="modulepreload">
<link href="/_app/immutable/chunks/Dt-HX3Vu.js" rel="modulepreload">
<link href="/_app/immutable/entry/app.C2SVyiZs.js" rel="modulepreload">
<link href="/_app/immutable/entry/app.BaC2bvUy.js" rel="modulepreload">
<link href="/_app/immutable/chunks/HclGiUj8.js" rel="modulepreload">
<link href="/_app/immutable/chunks/xihTtKlq.js" rel="modulepreload">
<link href="/_app/immutable/nodes/0.DmQX232Z.js" rel="modulepreload">
Expand All @@ -125,7 +125,7 @@

Promise.all([
import("/_app/immutable/entry/start.CRNCrUAM.js"),
import("/_app/immutable/entry/app.C2SVyiZs.js")
import("/_app/immutable/entry/app.BaC2bvUy.js")
]).then(([kit, app]) => {
kit.start(app, element);
});
Expand Down
20 changes: 19 additions & 1 deletion .../immutable/assets/pdf.worker.CLesOks4.mjs → .../immutable/assets/pdf.worker.D3ahraH8.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38722,6 +38722,24 @@ function clearGlobalCaches() {



function normalizeFileSpecFilename(filename) {
let normalized = "";
for (let index = 0; index < filename.length; index++) {
const char = filename[index];
if (char !== "\\") {
normalized += char;
continue;
}
if (filename[index + 1] === "\\") {
index++;
}
if (filename[index + 1] === "/") {
index++;
}
normalized += "/";
}
return normalized;
}

class FileSpec {
constructor(root) {
Expand All @@ -38739,7 +38757,7 @@ class FileSpec {
get filename() {
const item = FileSpec.pickPlatformItem(this.root);
if (item && typeof item === "string") {
return stringToPDFString(item, true).replaceAll("\\\\", "\\").replaceAll("\\/", "/").replaceAll("\\", "/");
return normalizeFileSpecFilename(stringToPDFString(item, true));
}
return "";
}
Expand Down
2 changes: 1 addition & 1 deletion ...ts/dist/_app/immutable/chunks/MLxiUYod.js → ...ts/dist/_app/immutable/chunks/AaSaDaz_.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions ...dist/_app/immutable/entry/app.C2SVyiZs.js → ...dist/_app/immutable/entry/app.BaC2bvUy.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .../dist/_app/immutable/nodes/11.DO_po0TK.js → .../dist/_app/immutable/nodes/11.b9OKMAue.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...s/dist/_app/immutable/nodes/3.CK36do99.js → ...s/dist/_app/immutable/nodes/3.2Wk-nB5d.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...s/dist/_app/immutable/nodes/4.D84CiE6m.js → ...s/dist/_app/immutable/nodes/4.DDi0b6Ps.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...s/dist/_app/immutable/nodes/5.B91Li3qf.js → ...s/dist/_app/immutable/nodes/5.Cs3czzXQ.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions apps/api/internal/webassets/dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,14 @@
<link href="./_app/immutable/chunks/uCPLfb5l.js" rel="modulepreload">
<link href="./_app/immutable/chunks/DK3Fl9T5.js" rel="modulepreload">
<link href="./_app/immutable/chunks/Dt-HX3Vu.js" rel="modulepreload">
<link href="./_app/immutable/entry/app.C2SVyiZs.js" rel="modulepreload">
<link href="./_app/immutable/entry/app.BaC2bvUy.js" rel="modulepreload">
<link href="./_app/immutable/chunks/HclGiUj8.js" rel="modulepreload">
<link href="./_app/immutable/chunks/xihTtKlq.js" rel="modulepreload">
<link href="./_app/immutable/nodes/0.DmQX232Z.js" rel="modulepreload">
<link href="./_app/immutable/chunks/D_03Opfq.js" rel="modulepreload">
<link href="./_app/immutable/chunks/BdJTOwvq.js" rel="modulepreload">
<link href="./_app/immutable/chunks/EVV9TJOL.js" rel="modulepreload">
<link href="./_app/immutable/nodes/3.CK36do99.js" rel="modulepreload">
<link href="./_app/immutable/nodes/3.2Wk-nB5d.js" rel="modulepreload">
<link href="./_app/immutable/chunks/BdPWQrN9.js" rel="modulepreload">

<link href="./_app/immutable/assets/0.C0ts6lYR.css" rel="stylesheet">
Expand All @@ -128,7 +128,7 @@

Promise.all([
import("./_app/immutable/entry/start.CRNCrUAM.js"),
import("./_app/immutable/entry/app.C2SVyiZs.js")
import("./_app/immutable/entry/app.BaC2bvUy.js")
]).then(([kit, app]) => {
kit.start(app, element);
});
Expand Down
Loading