support for Windows multithreading - #76
Merged
Merged
Conversation
Member
|
@krzywonos according to the tests there seem to be issues. Can you check them? If you want, you can ignore ruff and pyright, but at least the tests need to pass. |
krzywonos
commented
Sep 10, 2026
| from oc_meta.run.meta.generate_csv import load_json_from_file | ||
|
|
||
| mp_method = "spawn" if os.name == "nt" else "forkserver" | ||
| mp_method = multiprocessing.get_context("forkserver") if os.name != "nt" else multiprocessing.get_context("spawn") |
Author
There was a problem hiding this comment.
yeah this was the issue causing tests to fail, I didn't notice that there's multiprocessing.get_context() outside of the ProcessPoolExecutor instead of inside like everywhere else
Author
|
those 16 tests in each coverage were failing because of the issue in the comment above, should be fine now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.