feat: add configurable request logging - #359
Closed
jbeckwith-oai wants to merge 2 commits into
Closed
Conversation
HAYDEN-OAI
reviewed
Aug 11, 2026
HAYDEN-OAI
left a comment
Contributor
There was a problem hiding this comment.
I found three substantive logging correctness/redaction issues inline.
Contributor
Author
|
Closing this draft because the response metadata, logging, and timeout work is being rebuilt together as one clean PR from current main. This avoids retaining the temporary stacked base and fragmented transport design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger:andlog_level:client optionsOPENAI_LOGwith:off,:error,:warn,:info, and:debuglevelsCloses #306.
Stacking and API compatibility
This PR is intentionally stacked on #262 because both changes touch the core transport pipeline. Since #262 comes from a fork and GitHub cannot use its head as an upstream base,
codex/request-response-logging-baseis an exact mirror of #262 head commit44c62911. The combined implementation routes ordinary and raw responses through the same logging lifecycle. This PR will be retargeted tomainafter #262 merges.I reviewed the other open PRs. #293 also touches
BaseClient, but introduces no competing public logging API; #347 and #358 overlap only generated release/docs surfaces. No open PR defineslogger,log_level, orOPENAI_LOG.Safety
Validation