Fixing build URIs - #76
Merged
Merged
Conversation
The Load and Validate cell in each example page hardcoded https://models.open223.info, so a local or branch build validated the published model rather than the one being edited. tools/model-base-url.sh now picks the base URL, and make-notebook.py bakes it into the page at generation time, keeping the cell a single copy-pasteable Model.from_file call: this checkout for any local build, the published site for CI on main, the branch's raw.githubusercontent path for CI on a branch. OPEN223_MODEL_BASE_URL overrides it. Because the URL is written into tracked markdown, a .model-base-url stamp forces the pages to regenerate whenever the base changes, `make publish-urls` restores the published URL before committing, and `make check-model-urls` (a CI step) fails if a non-published URL was committed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DwcfUpaJTkXM5dWQ3iZ1CY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.