Skip to content

43 pnnl example building 1 model 2 broken - #72

Merged
michaelpoplawskipnnl merged 2 commits into
mainfrom
43-pnnl-example-building-1-model-2-broken
Aug 26, 2026
Merged

michaelpoplawskipnnl merged 2 commits into
mainfrom
43-pnnl-example-building-1-model-2-broken

Conversation

@michaelpoplawskipnnl

Copy link
Copy Markdown
Collaborator

Updated model to latest version: trial 1

@michaelpoplawskipnnl michaelpoplawskipnnl linked an issue Aug 25, 2026 that may be closed by this pull request
@michaelpoplawskipnnl

Copy link
Copy Markdown
Collaborator Author

@gtfierro does deploy-book validate all the model files, or is it smart enough to just validate files that have changed as part of the pull request?

@gtfierro

Copy link
Copy Markdown
Contributor

I believe it currently rebuilds all of them. A failing model also won't fail the build. If you build locally and look at the built document, that should confirm if the new model is valid.

@gtfierro

Copy link
Copy Markdown
Contributor

You can use https://github.com/open223/models.open223.info#validate-or-build-one-model to build/validate a single model, for testing purposes (pull latest from main)

@michaelpoplawskipnnl

michaelpoplawskipnnl commented Aug 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

Thanks @gtfierro.

Given that all checks passed with no conflicts with base branch, I'm going to merge this PR, close the issue, and see where we are.

How long until these changes show up on the open223 website?

FYI, I'm going to keep this branch and issue open for now to support additional model updateviterations, if necessary.

@michaelpoplawskipnnl
michaelpoplawskipnnl merged commit 56eb849 into main Aug 26, 2026
1 check passed
@michaelpoplawskipnnl

Copy link
Copy Markdown
Collaborator Author

@gtfierro how long does it take for a new build to show up on the website?

  • I see that the the new model is available here: https://models.open223.info/pnnl-bdg1-2.ttl
  • However, the validation output is still from the previous model
  • On a related note, is it possible to put a time stamp or some UID in the validation output so we know that it is associated with the current downloadable model (which ideally would also have a time stamp or UID)
  • Is it possible to add a "Copy to clipboard" button for the validation output, similar to the one that is there for the validation code?

@gtfierro

Copy link
Copy Markdown
Contributor

Hi @michaelpoplawskipnnl GitHub has been having some issues recently, so there could be some delay. However, in this case, I think the problem is that your updated TTL file does not contain an ontology declaration, which messes up all the tools. The existing tooling has not been super helpful in detecting or reporting these issues, hence why the build passed even though there was still a problem.

On my new branch, you can more clearly see the problem: https://github.com/open223/models.open223.info/actions/runs/33193473373/job/98924590728

@michaelpoplawskipnnl

Copy link
Copy Markdown
Collaborator Author

@gtfierro thanks for your feedback!
Yes, we hadn't been adding that to our raw graphs.
I just added a declaration, and pulled a new merge request.
#75
Fingers crossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PNNL Example Building 1 Model 2 broken

2 participants