Skip to content

Add host.id resource detector #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaydeluca wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add host.id resource detector #4843

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d4e7a04
add host id resource detector
jaydeluca Jul 17, 2026
327dc1b
use non deprecated semconv ref
jaydeluca Jul 20, 2026
4ab63e0
cleanups
jaydeluca Jul 20, 2026
c306980
update changelog with PR number
jaydeluca Jul 20, 2026
5878cec
fix import
jaydeluca Jul 20, 2026
f341fe6
Merge branch 'main' into resource-detector-host
herin049 Jul 22, 2026
89ca8be
opt in to type checking, add end to end tests, use full path checking…
jaydeluca Jul 22, 2026
43d1c03
fix minimum version for semconv compliance, ensure CI runs on a windo…
jaydeluca Jul 22, 2026
5a1338e
undo windows test runner changes
jaydeluca Jul 22, 2026
c5bbb24
Merge branch 'main' into resource-detector-host
jaydeluca Jul 22, 2026
12b0176
change log levels, make assertiosn stronger
jaydeluca Jul 24, 2026
08af83f
make the name more specific to hostid to reduce confusion
jaydeluca Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/4843.added
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-resource-detector-host`: add detector setting `host.id` from the non-privileged machine id
30 changes: 30 additions & 0 deletions .github/workflows/core_contrib_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,36 @@ jobs:
- name: Run tests
run: tox -e py310-test-resource-detector-containerid -- -ra

py310-test-resource-detector-host:
name: resource-detector-host
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout contrib repo @ SHA - ${{ env.CONTRIB_REPO_SHA }}
uses: actions/checkout@v4
with:
repository: open-telemetry/opentelemetry-python-contrib
ref: ${{ env.CONTRIB_REPO_SHA }}

- name: Checkout core repo @ SHA - ${{ env.CORE_REPO_SHA }}
uses: actions/checkout@v4
with:
repository: open-telemetry/opentelemetry-python
ref: ${{ env.CORE_REPO_SHA }}
path: opentelemetry-python

- name: Set up Python 3.10
uses: actions/setup-python@v5
with:
python-version: "3.10"
architecture: "x64"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e py310-test-resource-detector-host -- -ra

py310-test-resource-detector-azure-0:
name: resource-detector-azure-0
runs-on: ubuntu-latest
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,25 @@ jobs:
- name: Run tests
run: tox -e lint-resource-detector-containerid

lint-resource-detector-host:
name: resource-detector-host
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v4

- name: Set up Python 3.14
uses: actions/setup-python@v5
with:
python-version: "3.14"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e lint-resource-detector-host

lint-resource-detector-azure:
name: resource-detector-azure
runs-on: ubuntu-latest
Expand Down
114 changes: 114 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,120 @@ jobs:
- name: Run tests
run: tox -e pypy3-test-resource-detector-containerid -- -ra

py310-test-resource-detector-host_ubuntu-latest:
name: resource-detector-host 3.10 Ubuntu
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v4

- name: Set up Python 3.10
uses: actions/setup-python@v5
with:
python-version: "3.10"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e py310-test-resource-detector-host -- -ra

py311-test-resource-detector-host_ubuntu-latest:
name: resource-detector-host 3.11 Ubuntu
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v4

- name: Set up Python 3.11
uses: actions/setup-python@v5
with:
python-version: "3.11"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e py311-test-resource-detector-host -- -ra

py312-test-resource-detector-host_ubuntu-latest:
name: resource-detector-host 3.12 Ubuntu
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v4

- name: Set up Python 3.12
uses: actions/setup-python@v5
with:
python-version: "3.12"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e py312-test-resource-detector-host -- -ra

py313-test-resource-detector-host_ubuntu-latest:
name: resource-detector-host 3.13 Ubuntu
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v4

- name: Set up Python 3.13
uses: actions/setup-python@v5
with:
python-version: "3.13"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e py313-test-resource-detector-host -- -ra

py314-test-resource-detector-host_ubuntu-latest:
name: resource-detector-host 3.14 Ubuntu
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v4

- name: Set up Python 3.14
uses: actions/setup-python@v5
with:
python-version: "3.14"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e py314-test-resource-detector-host -- -ra

pypy3-test-resource-detector-host_ubuntu-latest:
name: resource-detector-host pypy-3.10 Ubuntu
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v4

- name: Set up Python pypy-3.10
uses: actions/setup-python@v5
with:
python-version: "pypy-3.10"

- name: Install tox
run: pip install tox-uv

- name: Run tests
run: tox -e pypy3-test-resource-detector-host -- -ra

py310-test-resource-detector-azure-0_ubuntu-latest:
name: resource-detector-azure-0 3.10 Ubuntu
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ install <https://pip.pypa.io/en/stable/reference/pip_install/#editable-installs>
pip install -e ./instrumentation-genai/opentelemetry-instrumentation-openai-v2
pip install -e ./sdk-extension/opentelemetry-sdk-extension-aws
pip install -e ./resource/opentelemetry-resource-detector-containerid
pip install -e ./resource/opentelemetry-resource-detector-host

@emdneto emdneto Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the package name like this can create confusion with the default HostResourceDetector in the SDK. Maybe rename it to hostid, host-id?

Maybe I'm being conservative here from the user perspective, but just sharing some thoughts.

@jaydeluca jaydeluca Jul 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree, i'm going to update it, thanks

.. toctree::
Expand Down
7 changes: 7 additions & 0 deletions docs/resource/host/host.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
OpenTelemetry Python - Host ID Resource Detector
================================================

.. automodule:: opentelemetry.resource.detector.host
:members:
:undoc-members:
:show-inheritance:
Loading
Loading