Skip to content

fix(ui): marketplace widget sub-header to 14px / regular / text-secondary - #31160

Merged
siddhant1 merged 1 commit into
mainfrom
subheader-font-size-fix
Aug 7, 2026
Merged

fix(ui): marketplace widget sub-header to 14px / regular / text-secondary#31160
siddhant1 merged 1 commit into
mainfrom
subheader-font-size-fix

Conversation

@siddhant1

@siddhant1 siddhant1 commented Aug 7, 2026

Copy link
Copy Markdown
Member

Describe your changes:

The "Recently Created …" line under New Data Products / New Domains on the Data Marketplace landing page rendered at 14px / weight 500 / text-primary — the same colour and nearly the same weight as the heading directly above it, so it read as a second title rather than supporting copy. It now renders at 14px / weight 400 / text-secondary, matching the design spec.

  • MarketplaceDataProductsWidget.component.tsx
  • MarketplaceDomainsWidget.component.tsx

Size and weight move onto the Typography size/weight props, matching the sibling h5 heading and AnnouncementsWidgetV2; the colour class uses the same tw:text-text-* form as the heading right above it. No core-component change.

Type of change:

  • Improvement

High-level design:

N/A — three-line style change in two components.

Tests:

Use cases covered

  • Data Marketplace landing page (/data-marketplace): the "Recently Created Data Products" and "Recently Created Domains" sub-headers render as 14px / 400 / #414651.
  • tw:text-text-secondary is theme-aware, so the same line follows --color-text-secondary to gray-300 in dark mode (the previous tw:text-text-primary also was; this only changes which token it points at).

Unit tests

  • Not applicable — no logic change. A test asserting the className/props would be brittle and would not catch a real regression; the styling is verified by measured computed style below.

Backend integration tests

  • Not applicable (no backend API changes).

Ingestion integration tests

  • Not applicable (no ingestion changes).

Playwright (UI) tests

  • Not applicable — no behavioural change; nothing new to drive.

Manual testing performed

  1. Ran the UI dev server from this branch against a local backend, logged in as admin, opened Data Marketplace.

  2. Measured the live computed style of both sub-headers, on the same running stack, with and without this commit applied:

    font-size font-weight color
    Before 14px 500 rgb(24, 29, 39)#181d27
    After 14px 400 rgb(65, 70, 81)#414651
  3. Confirmed the generated utilities resolve as intended by compiling src/styles/tailwind.css with the project's own Tailwind: tw:text-smcalc(4px * 3.5) = 14px, tw:font-normal → 400, tw:text-text-secondary--color-text-secondary#414651.

UI screen recording / screenshots:

Before — 14px / 500 / #181d27 After — 14px / 400 / #414651
Data Products
Domains

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation> — no issue; follows the same convention as fix(ui): marketplace widget sub-header style + cover-image dimension validation #30312, which set this sub-header's previous style.
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: not applicable.
  • For UI changes: I attached before/after screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

🤖 Generated with Claude Code

@siddhant1
siddhant1 requested a review from a team as a code owner August 7, 2026 07:10
Copilot AI review requested due to automatic review settings August 7, 2026 07:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

siddhant1 added a commit to siddhant1/OpenMetadata that referenced this pull request Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

siddhant1 added a commit to siddhant1/OpenMetadata that referenced this pull request Aug 7, 2026
siddhant1 added a commit to siddhant1/OpenMetadata that referenced this pull request Aug 7, 2026
siddhant1 added a commit to siddhant1/OpenMetadata that referenced this pull request Aug 7, 2026
@github-actions github-actions Bot added the UI UI specific issues label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit e92c00176a7f981fc2529483801fe2105113eaf9 in Playwright run 31167687773, attempt 1.

✅ 550 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 51m 47s

⏱️ Max setup 3m 34s · max shard execution 17m 38s · max shard-job elapsed before upload 21m 3s · reporting 3s

🌐 202.68 requests/attempt · 2.83 app boots/UI scenario · 20.23% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 20.23% (convergence target: at most 15%).
  • Browser traffic was 202.68 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1618 boots / 571 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 137 0 0 0 0 0
✅ Shard chromium-02 126 0 0 0 0 0
✅ Shard chromium-03 136 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@siddhant1 siddhant1 added the safe to test Add this label to run secure Github workflows on PRs label Aug 7, 2026
The "Recently Created …" line on the Data Products and Domains marketplace
widgets rendered at 14px / weight 500 / text-primary, which read as a second
title next to the widget heading. Drop it to weight 400 and text-secondary so
it reads as supporting copy.

Size and weight move onto the Typography `size`/`weight` props, and the colour
class matches the `tw:text-text-primary` already used on the sibling heading —
both resolve through `--color-text-secondary` / `--color-text-primary`.

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 7, 2026 07:15
@siddhant1
siddhant1 force-pushed the subheader-font-size-fix branch from 5016e3a to e92c001 Compare August 7, 2026 07:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@siddhant1
siddhant1 enabled auto-merge August 7, 2026 07:17
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.22% (78152/118018) 50.22% (47201/93982) 51.43% (14220/27645)

@siddhant1 siddhant1 added To release Will cherry-pick this PR into the release branch safe to test Add this label to run secure Github workflows on PRs and removed safe to test Add this label to run secure Github workflows on PRs labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ UI Checkstyle passed — lint findings in changed files

🔍 ESLint findings in this PR's files — 0 error(s), 4 warning(s)

Errors block the build. Warnings do not yet — they are rules whose backlog is still
being worked down, listed so this PR does not add to it. See docs/ui-code-quality-gate.md.

0 error(s), 4 warning(s) across 2 changed file(s).

Count Rule
4 sonarjs/no-duplicate-string
All findings
Location Rule Message
🟡 src/components/DataMarketplace/MarketplaceDataProductsWidget/MarketplaceDataProductsWidget.component.tsx:113:26 sonarjs/no-duplicate-string Define a constant instead of duplicating this literal 3 times.
🟡 src/components/DataMarketplace/MarketplaceDataProductsWidget/MarketplaceDataProductsWidget.component.tsx:224:33 sonarjs/no-duplicate-string Define a constant instead of duplicating this literal 3 times.
🟡 src/components/DataMarketplace/MarketplaceDomainsWidget/MarketplaceDomainsWidget.component.tsx:106:26 sonarjs/no-duplicate-string Define a constant instead of duplicating this literal 3 times.
🟡 src/components/DataMarketplace/MarketplaceDomainsWidget/MarketplaceDomainsWidget.component.tsx:207:33 sonarjs/no-duplicate-string Define a constant instead of duplicating this literal 3 times.

Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚦 Removed from the merge queue — failed_checks (2026-08-07T16:24:23Z)

Blocked the queue: playwright-summary

@siddhant1
siddhant1 added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit b07117a Aug 7, 2026
228 of 233 checks passed
@siddhant1
siddhant1 deleted the subheader-font-size-fix branch August 7, 2026 22:22
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 2.0 branch.

github-actions Bot pushed a commit that referenced this pull request Aug 7, 2026
…31160)

The "Recently Created …" line on the Data Products and Domains marketplace
widgets rendered at 14px / weight 500 / text-primary, which read as a second
title next to the widget heading. Drop it to weight 400 and text-secondary so
it reads as supporting copy.

Size and weight move onto the Typography `size`/`weight` props, and the colour
class matches the `tw:text-text-primary` already used on the sibling heading —
both resolve through `--color-text-secondary` / `--color-text-primary`.

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit b07117a)
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.13 branch.
Please cherry-pick the changes manually.
You can find more details here.

@gitar-bot

gitar-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Updates the marketplace widget sub-headers to 14px / regular / text-secondary, resolving the invalid tw:text-secondary utility finding. No issues found.

✅ 1 resolved
Bug: className "tw:text-secondary" is not a valid color utility

📄 openmetadata-ui/src/main/resources/ui/src/components/DataMarketplace/MarketplaceDataProductsWidget/MarketplaceDataProductsWidget.component.tsx:228 📄 openmetadata-ui/src/main/resources/ui/src/components/DataMarketplace/MarketplaceDomainsWidget/MarketplaceDomainsWidget.component.tsx:211
The new className="tw:text-secondary" won't apply the intended text-secondary color: there is no --color-secondary token (only scaled secondary-700 etc. and the --color-text-secondary token), and no other file in the repo uses the bare tw:text-secondary class. The design-system token for this color is tw:text-text-secondary (var --color-text-secondary), so the sub-header text will fall back to its inherited color instead of text-secondary, defeating the PR's purpose. Use className="tw:text-text-secondary" (or the Typography color="secondary" prop, which maps to tw:text-tertiary).

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants