fix(ui): marketplace widget sub-header to 14px / regular / text-secondary - #31160
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 550 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 51m 47s ⏱️ Max setup 3m 34s · max shard execution 17m 38s · max shard-job elapsed before upload 21m 3s · reporting 3s 🌐 202.68 requests/attempt · 2.83 app boots/UI scenario · 20.23% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
The "Recently Created …" line on the Data Products and Domains marketplace widgets rendered at 14px / weight 500 / text-primary, which read as a second title next to the widget heading. Drop it to weight 400 and text-secondary so it reads as supporting copy. Size and weight move onto the Typography `size`/`weight` props, and the colour class matches the `tw:text-text-primary` already used on the sibling heading — both resolve through `--color-text-secondary` / `--color-text-primary`. Co-Authored-By: Claude <noreply@anthropic.com>
5016e3a to
e92c001
Compare
|
| Count | Rule |
|---|---|
| 4 | sonarjs/no-duplicate-string |
All findings
| Location | Rule | Message | |
|---|---|---|---|
| 🟡 | src/components/DataMarketplace/MarketplaceDataProductsWidget/MarketplaceDataProductsWidget.component.tsx:113:26 |
sonarjs/no-duplicate-string |
Define a constant instead of duplicating this literal 3 times. |
| 🟡 | src/components/DataMarketplace/MarketplaceDataProductsWidget/MarketplaceDataProductsWidget.component.tsx:224:33 |
sonarjs/no-duplicate-string |
Define a constant instead of duplicating this literal 3 times. |
| 🟡 | src/components/DataMarketplace/MarketplaceDomainsWidget/MarketplaceDomainsWidget.component.tsx:106:26 |
sonarjs/no-duplicate-string |
Define a constant instead of duplicating this literal 3 times. |
| 🟡 | src/components/DataMarketplace/MarketplaceDomainsWidget/MarketplaceDomainsWidget.component.tsx:207:33 |
sonarjs/no-duplicate-string |
Define a constant instead of duplicating this literal 3 times. |
Fix locally (fast - only checks files changed in this branch):
make ui-checkstyle-changed
|
🚦 Removed from the merge queue —
|
|
Changes have been cherry-picked to the 2.0 branch. |
…31160) The "Recently Created …" line on the Data Products and Domains marketplace widgets rendered at 14px / weight 500 / text-primary, which read as a second title next to the widget heading. Drop it to weight 400 and text-secondary so it reads as supporting copy. Size and weight move onto the Typography `size`/`weight` props, and the colour class matches the `tw:text-text-primary` already used on the sibling heading — both resolve through `--color-text-secondary` / `--color-text-primary`. Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit b07117a)
|
Failed to cherry-pick changes to the 1.13 branch. |
Code Review ✅ Approved 1 resolved / 1 findingsUpdates the marketplace widget sub-headers to 14px / regular / text-secondary, resolving the invalid tw:text-secondary utility finding. No issues found. ✅ 1 resolved✅ Bug: className "tw:text-secondary" is not a valid color utility
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |



Describe your changes:
The "Recently Created …" line under New Data Products / New Domains on the Data Marketplace landing page rendered at 14px / weight 500 /
text-primary— the same colour and nearly the same weight as the heading directly above it, so it read as a second title rather than supporting copy. It now renders at 14px / weight 400 / text-secondary, matching the design spec.MarketplaceDataProductsWidget.component.tsxMarketplaceDomainsWidget.component.tsxSize and weight move onto the
Typographysize/weightprops, matching the siblingh5heading andAnnouncementsWidgetV2; the colour class uses the sametw:text-text-*form as the heading right above it. No core-component change.Type of change:
High-level design:
N/A — three-line style change in two components.
Tests:
Use cases covered
/data-marketplace): the "Recently Created Data Products" and "Recently Created Domains" sub-headers render as 14px / 400 /#414651.tw:text-text-secondaryis theme-aware, so the same line follows--color-text-secondaryto gray-300 in dark mode (the previoustw:text-text-primaryalso was; this only changes which token it points at).Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
Ran the UI dev server from this branch against a local backend, logged in as admin, opened Data Marketplace.
Measured the live computed style of both sub-headers, on the same running stack, with and without this commit applied:
font-sizefont-weightcolorrgb(24, 29, 39)—#181d27rgb(65, 70, 81)—#414651Confirmed the generated utilities resolve as intended by compiling
src/styles/tailwind.csswith the project's own Tailwind:tw:text-sm→calc(4px * 3.5)= 14px,tw:font-normal→ 400,tw:text-text-secondary→--color-text-secondary→#414651.UI screen recording / screenshots:
#181d27#414651Checklist:
Fixes <issue-number>: <short explanation>— no issue; follows the same convention as fix(ui): marketplace widget sub-header style + cover-image dimension validation #30312, which set this sub-header's previous style.Fixes #<issue-number>above.🤖 Generated with Claude Code