-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixed context center bugs #31118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rohit0301
wants to merge
12
commits into
main
Choose a base branch
from
context-center-bug-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed context center bugs #31118
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
83db6dd
Fixed context center bugs
Rohit0301 b7205a6
addressed gitar comment
Rohit0301 e606c1b
lint fix
Rohit0301 0836510
minor fix
Rohit0301 3a166fb
fixed playwright spec
Rohit0301 882c55f
lint fix
Rohit0301 6fd1bdd
addressed gitar comment
Rohit0301 c9b396f
minor fixed
Rohit0301 fb9562f
lint fix
Rohit0301 414de6e
minor fix
Rohit0301 ad60a4a
fixed pagination loader
Rohit0301 041c677
lint fix
Rohit0301 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
...c/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Copyright 2026 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { fireEvent, render, screen } from '@testing-library/react'; | ||
| import { ReactComponent as FileIcon } from '../../../assets/svg/common/file.svg'; | ||
| import ContextKnowledgePillarCard from './ContextKnowledgePillarCard.component'; | ||
| import { PillarRecentItem } from './ContextKnowledgePillarCard.interface'; | ||
|
|
||
| jest.mock('react-i18next', () => ({ | ||
| useTranslation: () => ({ t: (key: string) => key }), | ||
| })); | ||
|
|
||
| const baseProps = { | ||
| cta: 'View all', | ||
| icon: FileIcon, | ||
| stat: '5', | ||
| statSub: 'items', | ||
| subtitle: 'subtitle', | ||
| title: 'Articles', | ||
| }; | ||
|
|
||
| describe('ContextKnowledgePillarCard', () => { | ||
| it('calls onClick when the card body is clicked', () => { | ||
| const onClick = jest.fn(); | ||
| render( | ||
| <ContextKnowledgePillarCard | ||
| {...baseProps} | ||
| dataTestId="article-detail-card" | ||
| recent={[{ meta: [], onClick: jest.fn(), title: 'Item 1' }]} | ||
| onClick={onClick} | ||
| /> | ||
| ); | ||
|
|
||
| fireEvent.click(screen.getByTestId('article-detail-card')); | ||
|
|
||
| expect(onClick).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| it('calls the item onClick and not the card onClick when a recent item with onClick is clicked', () => { | ||
| const onCardClick = jest.fn(); | ||
| const onItemClick = jest.fn(); | ||
| const recent: PillarRecentItem[] = [ | ||
| { meta: [], onClick: onItemClick, title: 'Item 1' }, | ||
| ]; | ||
| render( | ||
| <ContextKnowledgePillarCard | ||
| {...baseProps} | ||
| dataTestId="article-detail-card" | ||
| recent={recent} | ||
| onClick={onCardClick} | ||
| /> | ||
| ); | ||
|
|
||
| fireEvent.click(screen.getByRole('button', { name: 'Item 1' })); | ||
|
|
||
| expect(onItemClick).toHaveBeenCalledTimes(1); | ||
| expect(onCardClick).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('calls onClick when the CTA button is clicked, without double-firing from the card', () => { | ||
| const onClick = jest.fn(); | ||
| render( | ||
| <ContextKnowledgePillarCard | ||
| {...baseProps} | ||
| dataTestId="article-detail-card" | ||
| recent={[{ meta: [], onClick: jest.fn(), title: 'Item 1' }]} | ||
| onClick={onClick} | ||
| /> | ||
| ); | ||
|
|
||
| fireEvent.click(screen.getByRole('button', { name: 'View all' })); | ||
|
|
||
| expect(onClick).toHaveBeenCalledTimes(1); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.