Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed

- 🐞 **model**: Fit GaussianKDE on the original data and honour the constructor dataset by @sohailshk in https://github.com/open-edge-platform/anomalib/pull/3921
- 🐞 **model**: Keep PatchCore's batch size dynamic when exporting by @varunikarai in https://github.com/open-edge-platform/anomalib/pull/3853
- πŸ“š **docs**: Align custom-data, export, benchmark, and Lightning examples with current APIs

Expand Down
8 changes: 4 additions & 4 deletions src/anomalib/models/components/stats/kde.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ class GaussianKDE(DynamicBufferMixin):
def __init__(self, dataset: torch.Tensor | None = None) -> None:
super().__init__()

if dataset is not None:
self.fit(dataset)

self.register_buffer("bw_transform", torch.empty(0))
self.register_buffer("dataset", torch.empty(0))
self.register_buffer("norm", torch.empty(0))
Expand All @@ -62,6 +59,9 @@ def __init__(self, dataset: torch.Tensor | None = None) -> None:
self.dataset = torch.empty(0)
self.norm = torch.empty(0)

if dataset is not None:
self.fit(dataset)

def forward(self, features: torch.Tensor) -> torch.Tensor:
"""Compute KDE estimates for the input features.

Expand Down Expand Up @@ -143,5 +143,5 @@ def cov(tensor: torch.Tensor) -> torch.Tensor:
torch.Size([5, 5])
"""
mean = torch.mean(tensor, dim=1)
tensor -= mean[:, None]
tensor = tensor - mean[:, None]
return torch.matmul(tensor, tensor.T) / (tensor.size(1) - 1)
4 changes: 4 additions & 0 deletions tests/unit/models/components/stats/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Copyright (C) 2026 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

"""Tests for statistics components."""
58 changes: 58 additions & 0 deletions tests/unit/models/components/stats/test_kde.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# Copyright (C) 2026 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

"""Unit tests for the GaussianKDE component."""

import pytest
import torch
from torch.distributions import MultivariateNormal

from anomalib.models.components.stats import GaussianKDE


@pytest.fixture
def offset_data() -> torch.Tensor:
"""Samples whose mean is far from the origin."""
generator = torch.Generator().manual_seed(0)
return torch.randn(200, 3, generator=generator) + torch.tensor([4.0, -2.0, 1.0])


def _reference_density(dataset: torch.Tensor, queries: torch.Tensor) -> torch.Tensor:
"""Gaussian KDE with Scott's rule: kernel covariance is ``factor**2`` times the data covariance."""
num_samples, dimension = dataset.shape
factor = num_samples ** (-1 / (dimension + 4))
kernel_covariance = factor**2 * torch.cov(dataset.T)
densities = [
MultivariateNormal(point, covariance_matrix=kernel_covariance).log_prob(dataset).exp().mean()
for point in queries
]
return torch.stack(densities)


def test_density_matches_reference_for_off_center_data(offset_data: torch.Tensor) -> None:
"""The estimate equals the textbook KDE even when the data mean is not zero."""
queries = offset_data[:5] + 0.1
kde = GaussianKDE()
kde.fit(offset_data.clone())

assert torch.allclose(kde(queries), _reference_density(offset_data, queries), rtol=1e-3)


def test_fit_does_not_modify_the_dataset(offset_data: torch.Tensor) -> None:
"""Fitting leaves the caller's tensor untouched."""
dataset = offset_data.clone()

GaussianKDE().fit(dataset)

assert torch.equal(dataset, offset_data)


def test_dataset_passed_to_the_constructor_is_fitted(offset_data: torch.Tensor) -> None:
"""``GaussianKDE(dataset=...)`` yields a fitted model equal to calling ``fit`` afterwards."""
queries = offset_data[:5] + 0.1
fitted_later = GaussianKDE()
fitted_later.fit(offset_data.clone())

fitted_in_constructor = GaussianKDE(dataset=offset_data.clone())

assert torch.allclose(fitted_in_constructor(queries), fitted_later(queries))