Repository navigation
ci: Pin geti-ci actions in workflows - #3831
Conversation
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The release SHAs match their documented tags, and the Renovate configuration satisfies the linked issue.
Review effort: Balanced
Findings: None
What changed in this PR
Pins geti-ci actions to component release SHAs and restores automated Renovate lock-file maintenance.
Changes:
- Pins workflow actions to verified release-tag commits.
- Adds Renovate support for component-prefixed tags.
- Re-enables lock-file automerge.
| File | Description |
|---|---|
.github/workflows/tauri-build.yaml |
Pins check-paths. |
.github/workflows/publish-rc-app.yml |
Pins sign-image. |
.github/workflows/promote-rc-app-release.yml |
Pins sign-image. |
.github/workflows/pr.yaml |
Pins both check-paths uses. |
.github/workflows/daily-docker-publish.yml |
Pins sign-image. |
.github/workflows/anomalib-studio.yaml |
Pins check-paths. |
.github/workflows/_reusable-security-scan.yaml |
Pins Bandit and Zizmor actions. |
.github/workflows/_reusable-docker-build.yaml |
Pins cleanup actions. |
.github/renovate.json5 |
Restores automerge and supports component tags. |
.github/actions/docker-build/action.yml |
Pins the cleanup action. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Docker Image SizesCPU
CUDA
XPU
|
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Renovate token omits required permissions, and the Zizmor override weakens security scanning.
Review effort: Balanced
Findings: 1
Open (1)
Previously missed (1)
In code that hasn't changed since last review

Incomplete GitHub App token permissions cause Renovate failures

.github/workflows/renovate.yml:82
Requesting any explicit permission inputs makes create-github-app-token issue a reduced token instead of inheriting the app's grants. This list omits permissions Renovate documents as required for its GitHub App—most notably checks, commit statuses, administration, Dependabot alerts, metadata, and members—so operations such as reading branch protection/statuses, vulnerability alerts, or resolving reviewers can fail with 403s. Include the complete Renovate permission set when narrowing this token.
AlexanderBarabanov
left a comment
There was a problem hiding this comment.
Thank you, Ivan! Several suggestions.
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Invalid local workflow references break core CI jobs, and the new Renovate rule does not match the extracted geti-ci package name.
Review effort: Balanced
Findings: 2
Open (7)
Thesepermission-*entries are action-specific inputs, but most GitHub App token actions don’t… Same issue as in the Renovate workflow: if the GitHub App token action used here doesn’t support… Match GitHub Action repository name in package rules Thesepermission-*inputs are nonstandard for most GitHub App token actions and may be silently… The cron expression* * 1 * *does not mean “every month”; it runs every minute on the 1st day of… The cron schedule* * 1 * *runs every minute for the entire 1st day of each month (not once per… Remove unnecessary organization-administration permission
Resolved since last review (3)
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Invalid reusable-workflow paths break key CI workflows, and the Renovate rule does not match geti-ci’s extracted package name.
Review effort: Balanced
Findings: 2
Open (7)
Thesepermission-*entries are action-specific inputs, but most GitHub App token actions don’t… Same issue as in the Renovate workflow: if the GitHub App token action used here doesn’t support… Match GitHub Action repository name in package rules Thesepermission-*inputs are nonstandard for most GitHub App token actions and may be silently… The cron expression* * 1 * *does not mean “every month”; it runs every minute on the 1st day of… The cron schedule* * 1 * *runs every minute for the entire 1st day of each month (not once per… Remove unnecessary organization-administration permission
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Invalid reusable-workflow paths break core CI jobs, and the Renovate rule does not match geti-ci dependencies.
Review effort: Balanced
Findings: 2
Open (8)
Thesepermission-*entries are action-specific inputs, but most GitHub App token actions don’t… Same issue as in the Renovate workflow: if the GitHub App token action used here doesn’t support… Unrelated vlm dependency constraint change lacks justification · New Match GitHub Action repository name in package rules Thesepermission-*inputs are nonstandard for most GitHub App token actions and may be silently… The cron expression* * 1 * *does not mean “every month”; it runs every minute on the 1st day of… The cron schedule* * 1 * *runs every minute for the entire 1st day of each month (not once per… Remove unnecessary organization-administration permission
Previously missed (1)
In code that hasn't changed since last review

Pinned historical test action skips validation of local changes

.github/workflows/_reusable-test-suite.yaml:122
This changes the repository-local test action into a fixed historical copy. Since pr.yaml explicitly triggers tests for changes under .github/actions/pytest/**, those PRs would run this old action instead of the modified checked-out action and therefore would not validate their change. Keep the local reference here.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Invalid reusable-workflow references break key CI jobs, while the Renovate matcher and root lockfile also require correction.
Review effort: Balanced
Findings: 3
Open (9)
Root uv.lock is stale · New Thesepermission-*entries are action-specific inputs, but most GitHub App token actions don’t… Same issue as in the Renovate workflow: if the GitHub App token action used here doesn’t support… Unrelated vlm dependency constraint change lacks justification Match GitHub Action repository name in package rules Thesepermission-*inputs are nonstandard for most GitHub App token actions and may be silently… The cron expression* * 1 * *does not mean “every month”; it runs every minute on the 1st day of… The cron schedule* * 1 * *runs every minute for the entire 1st day of each month (not once per… Remove unnecessary organization-administration permission
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Invalid reusable-workflow references break key CI workflows, and the Renovate rule does not match geti-ci dependencies.
Review effort: Balanced
Findings: 3
Open (9)
Root uv.lock is stale Thesepermission-*entries are action-specific inputs, but most GitHub App token actions don’t… Same issue as in the Renovate workflow: if the GitHub App token action used here doesn’t support… Unrelated vlm dependency constraint change lacks justification Match GitHub Action repository name in package rules Thesepermission-*inputs are nonstandard for most GitHub App token actions and may be silently… The cron expression* * 1 * *does not mean “every month”; it runs every minute on the 1st day of… The cron schedule* * 1 * *runs every minute for the entire 1st day of each month (not once per… Remove unnecessary organization-administration permission
AlexanderBarabanov
left a comment
There was a problem hiding this comment.
Thank you, Ivan!
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Invalid reusable-workflow paths break core CI workflows, and the Renovate rule does not match the intended package.
Review effort: Balanced
Findings: 2
Open (8)
Thesepermission-*entries are action-specific inputs, but most GitHub App token actions don’t… Same issue as in the Renovate workflow: if the GitHub App token action used here doesn’t support… Pinned action commit skips changes under review · New Match GitHub Action repository name in package rules Thesepermission-*inputs are nonstandard for most GitHub App token actions and may be silently… The cron expression* * 1 * *does not mean “every month”; it runs every minute on the 1st day of… The cron schedule* * 1 * *runs every minute for the entire 1st day of each month (not once per… Remove unnecessary organization-administration permission
Resolved since last review (2)
| persist-credentials: false | ||
| - name: Run tests | ||
| uses: ./.github/actions/pytest | ||
| uses: open-edge-platform/anomalib/.github/actions/pytest@1f503a6c3614e2637472cdb6d9ca21054c83ac26 |

📝 Description
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.