Skip to content

ci: Pin geti-ci actions in workflows - #3831

Merged
ashwinvaidya17 merged 18 commits into
mainfrom
ivanzati/pin-ci-actions
Oct 6, 2026
Merged

ashwinvaidya17 merged 18 commits into
mainfrom
ivanzati/pin-ci-actions

Conversation

@ivanzati

@ivanzati ivanzati commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
@ivanzati
ivanzati requested a review from a team as a code owner October 1, 2026 13:39
Copilot AI balanced review requested due to automatic review settings October 1, 2026 13:39
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 1, 2026 13:40 — with GitHub Actions Error
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 1, 2026 13:40 — with GitHub Actions Error
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 1, 2026 13:40 — with GitHub Actions Error

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The release SHAs match their documented tags, and the Renovate configuration satisfies the linked issue.

Review effort: Balanced
Findings: None

What changed in this PR

Pins geti-ci actions to component release SHAs and restores automated Renovate lock-file maintenance.

Changes:

  • Pins workflow actions to verified release-tag commits.
  • Adds Renovate support for component-prefixed tags.
  • Re-enables lock-file automerge.
File Description
.github/​workflows/​tauri-build.yaml Pins check-paths.
.github/​workflows/​publish-rc-app.yml Pins sign-image.
.github/​workflows/​promote-rc-app-release.yml Pins sign-image.
.github/​workflows/​pr.yaml Pins both check-paths uses.
.github/​workflows/​daily-docker-publish.yml Pins sign-image.
.github/​workflows/​anomalib-studio.yaml Pins check-paths.
.github/​workflows/​_reusable-security-scan.yaml Pins Bandit and Zizmor actions.
.github/​workflows/​_reusable-docker-build.yaml Pins cleanup actions.
.github/​renovate.json5 Restores automerge and supports component tags.
.github/​actions/​docker-build/​action.yml Pins the cleanup action.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Docker Image Sizes

CPU

Image Size
anomalib-studio-cpu:pr-3831 4.26G
anomalib-studio-cpu:sha-48b6865 4.26G

CUDA

Image Size
anomalib-studio-cuda:pr-3831 13.44G
anomalib-studio-cuda:sha-48b6865 13.44G

XPU

Image Size
anomalib-studio-xpu:pr-3831 12.91G
anomalib-studio-xpu:sha-48b6865 12.91G

Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 13:55
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 1, 2026 13:57 — with GitHub Actions Error
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 1, 2026 13:57 — with GitHub Actions Error
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 1, 2026 13:57 — with GitHub Actions Error

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The release SHAs, action inputs, permissions, and Renovate configuration align with the stated CI maintenance requirements.

Review effort: Balanced
Findings: None

Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:12
@ivanzati
ivanzati temporarily deployed to windows-msix-signing October 1, 2026 14:13 — with GitHub Actions Inactive
@ivanzati
ivanzati temporarily deployed to windows-msix-signing October 1, 2026 14:13 — with GitHub Actions Inactive
@ivanzati
ivanzati temporarily deployed to windows-msix-signing October 1, 2026 14:13 — with GitHub Actions Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Renovate token omits required permissions, and the Zizmor override weakens security scanning.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Incomplete GitHub App token permissions cause Renovate failures

.github/​workflows/​renovate.yml:82

Requesting any explicit permission inputs makes create-github-app-token issue a reduced token instead of inheriting the app's grants. This list omits permissions Renovate documents as required for its GitHub App—most notably checks, commit statuses, administration, Dependabot alerts, metadata, and members—so operations such as reading branch protection/statuses, vulnerability alerts, or resolving reviewers can fail with 403s. Include the complete Renovate permission set when narrowing this token.

@AlexanderBarabanov AlexanderBarabanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Ivan! Several suggestions.

Comment thread .github/workflows/renovate.yml Resolved
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 15:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 11:16
@ivanzati
ivanzati temporarily deployed to windows-msix-signing October 5, 2026 11:17 — with GitHub Actions Inactive
@ivanzati
ivanzati temporarily deployed to windows-msix-signing October 5, 2026 11:17 — with GitHub Actions Inactive
@ivanzati
ivanzati temporarily deployed to windows-msix-signing October 5, 2026 11:17 — with GitHub Actions Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 12:33
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 5, 2026 12:34 — with GitHub Actions Error
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 5, 2026 12:34 — with GitHub Actions Error
@ivanzati
ivanzati had a problem deploying to windows-msix-signing October 5, 2026 12:34 — with GitHub Actions Error
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>
@ivanzati
ivanzati requested a review from sys-geti as a code owner October 5, 2026 12:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Invalid reusable-workflow paths break core CI jobs, and the Renovate rule does not match geti-ci dependencies.

Review effort: Balanced
Findings: 2 High severity · 6 Medium severity

Open (8)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Pinned historical test action skips validation of local changes

.github/​workflows/​_reusable-test-suite.yaml:122

This changes the repository-local test action into a fixed historical copy. Since pr.yaml explicitly triggers tests for changes under .github/actions/pytest/**, those PRs would run this old action instead of the modified checked-out action and therefore would not validate their change. Keep the local reference here.

Comment thread pyproject.toml Resolved
Copilot AI balanced review requested due to automatic review settings October 5, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread pyproject.toml Resolved
Signed-off-by: Zakharov, Ivan <ivan.zakharov@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

@AlexanderBarabanov AlexanderBarabanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Ivan!

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

persist-credentials: false
- name: Run tests
uses: ./.github/actions/pytest
uses: open-edge-platform/anomalib/.github/actions/pytest@1f503a6c3614e2637472cdb6d9ca21054c83ac26

This branch was previously deployed

1 inactive deployment
windows-msix-signing — 84ea3e78 Deployed Oct 6, 2026 by ivanzati
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: pin action from geti-ci and Renovate config minor fix

6 participants