Skip to content

bump PartMC submodule - #560

Open
slayoo wants to merge 7 commits into
open-atmos:mainfrom
slayoo:bump_partmc
Open

slayoo wants to merge 7 commits into
open-atmos:mainfrom
slayoo:bump_partmc

Conversation

@slayoo

@slayoo slayoo commented Sep 25, 2026

Copy link
Copy Markdown
Member

No description provided.

@slayoo

slayoo commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

@jcurtis2, Jeff, some basic boilerplate changes addressed, but there will be a bit more work needed here to handle the spec_file_unread_line call, which we didn't have so far in PyPartMC's specfile-mimicking i/o layer.

@jcurtis2

Copy link
Copy Markdown
Member

@jcurtis2, Jeff, some basic boilerplate changes addressed, but there will be a bit more work needed here to handle the spec_file_unread_line call, which we didn't have so far in PyPartMC's specfile-mimicking i/o layer.

Thanks @slayoo. Having looked into this more, I think the better fix is on the PartMC side, with a small change to the spec file format. Right now PartMC peeks at the next line to see whether an optional drydep_params entry follows loss_function drydep. We don't handle optional parameters that way anywhere else. And its my best guess that it's awkward to reproduce with PyPartMC's JSON input.

The plan is to make it explicit, closer to how the chamber parameters are read. When loss_function is drydep, PartMC will read a drydep_use_defaults flag. If it's yes, the default parameters are used. If it's no, the parameters are read from a separate file given by drydep_params. This gets rid of the peek (spec_file_unread_line), so PyPartMC won't need to reproduce it. I'll open a PartMC PR for this and then update this one to match.

@slayoo

slayoo commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

Thanks, Jeff!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants