You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jcurtis2, Jeff, some basic boilerplate changes addressed, but there will be a bit more work needed here to handle the spec_file_unread_line call, which we didn't have so far in PyPartMC's specfile-mimicking i/o layer.
@jcurtis2, Jeff, some basic boilerplate changes addressed, but there will be a bit more work needed here to handle the spec_file_unread_line call, which we didn't have so far in PyPartMC's specfile-mimicking i/o layer.
Thanks @slayoo. Having looked into this more, I think the better fix is on the PartMC side, with a small change to the spec file format. Right now PartMC peeks at the next line to see whether an optional drydep_params entry follows loss_function drydep. We don't handle optional parameters that way anywhere else. And its my best guess that it's awkward to reproduce with PyPartMC's JSON input.
The plan is to make it explicit, closer to how the chamber parameters are read. When loss_function is drydep, PartMC will read a drydep_use_defaults flag. If it's yes, the default parameters are used. If it's no, the parameters are read from a separate file given by drydep_params. This gets rid of the peek (spec_file_unread_line), so PyPartMC won't need to reproduce it. I'll open a PartMC PR for this and then update this one to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.