Skip to content

Fix C++ README tests for Windows (currently disabled on the main branch) #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orzel320 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix C++ README tests for Windows (currently disabled on the main branch) #558

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a40981
Restored gcc update to newest version in buildwheels, explicitly buil…
orzel320 Sep 13, 2026
7b6b105
Switched back to UCRT64 in readme_cpp compilation
orzel320 Sep 13, 2026
fcb01ee
try if removing explicit nanobind linkage from the C++ example is OK
slayoo Sep 18, 2026
423b067
Add NOSTRIP option to nanobind_add_module
slayoo Sep 19, 2026
1c4cfa4
try disabling LTO
slayoo Sep 19, 2026
726242b
try using --whole-archive for Windows
slayoo Sep 19, 2026
9cfbcc7
Fix target link options syntax for Windows
slayoo Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/buildwheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
uses: msys2/setup-msys2@v2
with:
msystem: MINGW64
update: false
update: true
install: >-
mingw-w64-x86_64-gcc-fortran
mingw-w64-x86_64-ninja
Expand Down Expand Up @@ -365,10 +365,10 @@ jobs:
uses: msys2/setup-msys2@v2
with:
msystem: UCRT64
update: false
update: true
install: >-
mingw-w64-ucrt-x86_64-gcc
mingw-w64-ucrt-x86_64-ninja
mingw-w64-x86_64-gcc
mingw-w64-x86_64-ninja
m4

- if: matrix.os == 'windows-latest'
Expand Down
11 changes: 10 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,17 @@ set(PyPartMC_DIR "${PYPARTMC_CMAKE_DIR}")

find_package(PyPartMC REQUIRED)

@slayoo slayoo Sep 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orzel320, IIUC, this should not be needed as all these symbols should be inside the PyPartMC library. Also, since this is only happening on Windows, the fix should likely only modify what happens on Windows.

execute_process(
COMMAND ${Python_EXECUTABLE} -m nanobind --cmake_dir
OUTPUT_VARIABLE nanobind_ROOT
OUTPUT_STRIP_TRAILING_WHITESPACE
)
list(APPEND CMAKE_PREFIX_PATH "${nanobind_ROOT}")
find_package(nanobind CONFIG REQUIRED)
nanobind_build_library(nanobind-static)

add_executable(my_test test.cpp)
target_link_libraries(my_test PRIVATE PyPartMC::PyPartMC)
target_link_libraries(my_test PRIVATE PyPartMC::PyPartMC nanobind-static)
pypartmc_setup_runtime(my_test)

add_test(NAME maketest COMMAND my_test)
Expand Down
Loading