Repository navigation
fix: Don't free tracer context in DllMain during process termination - #544
Open
mschilling0 wants to merge 1 commit into
Open
mschilling0 wants to merge 1 commit into
mschilling0 wants to merge 1 commit into
Conversation
Matches what's being done here: https://learn.microsoft.com/en-us/windows/win32/dlls/dllmain `lpvReserved` is "non-NULL" when process is terminating and its not safe to call the tracer context destructor there. Signed-off-by: Schilling, Matthew <matthew.schilling@intel.com>
mschilling0
force-pushed
the
dev_windows
branch
from
October 22, 2026 17:25
57289ae to
5469123
Compare
mschilling0
changed the title
mschilling0
marked this pull request as ready for review
October 22, 2026 17:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches what's being done here: https://learn.microsoft.com/en-us/windows/win32/dlls/dllmain
lpvReservedis "non-NULL" when process is terminating and its not safe to call the tracer context destructor there.Guards against a use-after-free occasionally on PyTorch Profiler on Windows.